Fold widget/src/ into widget/

RESOLVED FIXED in mozilla12

Status

()

Core
Widget
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bbondy, Assigned: bbondy)

Tracking

unspecified
mozilla12
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [not-fennec-11])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
The contents of widget/src into  belong in widget.
(Assignee)

Comment 1

6 years ago
The above line should read: 
The contents of widget/src belong in widget/
(Assignee)

Updated

6 years ago
Assignee: netzen → nobody
Component: Widget: Win32 → Widget
QA Contact: win32 → general
(Assignee)

Updated

6 years ago
Assignee: nobody → netzen
Should we also move the contents of widget/public up one? If so, it would make sense to do it in this bug.
Yeah
(Assignee)

Updated

5 years ago
Blocks: 627956
No longer depends on: 627956
(Assignee)

Comment 4

5 years ago
Created attachment 585025 [details] [diff] [review]
Folded.  Patch v1.

Running through try before requesting review.  

Changes:
- Folded widget/src into widget
- Adjusted relative paths in Makefile.in files
- Did a :%s/widget\/src/widget\//g in the rest of the files
- Did a build locally and it worked (windows)
- Running through try for other platforms now
Comment on attachment 585025 [details] [diff] [review]
Folded.  Patch v1.

>--- a/accessible/accessible-docs.html
>+++ b/accessible/accessible-docs.html
> our case, this event is received in <a
>- href="http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsWindow.cpp#4370">mozilla/widget/src/windows/nsWindow.cpp</a>.
>+ href="http://lxr.mozilla.org/seamonkey/source/widget/windows/nsWindow.cpp#4370">mozilla/widget/windows/nsWindow.cpp</a>.

Want to make this point to m-c? The seamonkey tree is apparently used only by bugzilla.

>--- a/widget/src/windows/tests/Makefile.in
>+++ b/widget/windows/tests/Makefile.in
>+# XXX None of these stuff works in libxul builds.

I say it's time to remove it, then!
Also, widget/public?
It looks like some files in widget/(src/)windows/tests/ got their line ending convention changed; I don't know if that's desirable.

Please also move the contents of widget/public up one, per comments 2 and 3.  It would probably be clearest to do this in a second patch (also in this bug, however).
(Assignee)

Comment 8

5 years ago
> It looks like some files in widget/(src/)windows/tests/ got their line ending 
> convention changed; I don't know if that's desirable.

That was on purpose since those files end with windows line endings currently (CRLF) and it should be unix line endings (LF).


> Please also move the contents of widget/public up one, per comments 2 and 3.
> It would probably be clearest to do this in a second patch
> (also in this bug, however).

Will do regarding the widget/public.
(Assignee)

Comment 9

5 years ago
I'll leave the following to another bug by the way, please post a new bug with specifics.

> > --- a/widget/src/windows/tests/Makefile.in
> > +++ b/widget/windows/tests/Makefile.in
> > +# XXX None of these stuff works in libxul builds.

> I say it's time to remove it, then!
(Assignee)

Comment 10

5 years ago
Created attachment 585322 [details] [diff] [review]
Folded. Patch v2.

- Now also folded /widget/public into /widget
- Fixed URL to point to mozilla-central instead.

The last try result succeeded by the way but I'm re-pushing to try with the new changes before requesting review.
Attachment #585025 - Attachment is obsolete: true
(Assignee)

Comment 11

5 years ago
try run looks good:
https://tbpl.mozilla.org/?tree=Try&rev=c56aeade4b48
(Assignee)

Updated

5 years ago
Attachment #585322 - Flags: review?(roc)
Attachment #585322 - Flags: review?(roc) → review+
(Assignee)

Comment 12

5 years ago
Pushed to mozilla-inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/e57e271bf328
Target Milestone: --- → mozilla12
https://hg.mozilla.org/mozilla-central/rev/e57e271bf328
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [not-fennec-11]
You need to log in before you can comment on or make changes to this bug.