The contents of widget/src into belong in widget.
The above line should read:
The contents of widget/src belong in widget/
Should we also move the contents of widget/public up one? If so, it would make sense to do it in this bug.
Created attachment 585025 [details] [diff] [review]
Folded. Patch v1.
Running through try before requesting review.
- Folded widget/src into widget
- Adjusted relative paths in Makefile.in files
- Did a :%s/widget\/src/widget\//g in the rest of the files
- Did a build locally and it worked (windows)
- Running through try for other platforms now
Comment on attachment 585025 [details] [diff] [review]
Folded. Patch v1.
> our case, this event is received in <a
Want to make this point to m-c? The seamonkey tree is apparently used only by bugzilla.
>+# XXX None of these stuff works in libxul builds.
I say it's time to remove it, then!
It looks like some files in widget/(src/)windows/tests/ got their line ending convention changed; I don't know if that's desirable.
Please also move the contents of widget/public up one, per comments 2 and 3. It would probably be clearest to do this in a second patch (also in this bug, however).
> It looks like some files in widget/(src/)windows/tests/ got their line ending
> convention changed; I don't know if that's desirable.
That was on purpose since those files end with windows line endings currently (CRLF) and it should be unix line endings (LF).
> Please also move the contents of widget/public up one, per comments 2 and 3.
> It would probably be clearest to do this in a second patch
> (also in this bug, however).
Will do regarding the widget/public.
I'll leave the following to another bug by the way, please post a new bug with specifics.
> > --- a/widget/src/windows/tests/Makefile.in
> > +++ b/widget/windows/tests/Makefile.in
> > +# XXX None of these stuff works in libxul builds.
> I say it's time to remove it, then!
Created attachment 585322 [details] [diff] [review]
Folded. Patch v2.
- Now also folded /widget/public into /widget
- Fixed URL to point to mozilla-central instead.
The last try result succeeded by the way but I'm re-pushing to try with the new changes before requesting review.
try run looks good:
Pushed to mozilla-inbound: