Closed Bug 679226 Opened 10 years ago Closed 10 years ago
Fold widget/src/ into widget/
The contents of widget/src into belong in widget.
The above line should read: The contents of widget/src belong in widget/
Assignee: netzen → nobody
Component: Widget: Win32 → Widget
QA Contact: win32 → general
Should we also move the contents of widget/public up one? If so, it would make sense to do it in this bug.
Running through try before requesting review. Changes: - Folded widget/src into widget - Adjusted relative paths in Makefile.in files - Did a :%s/widget\/src/widget\//g in the rest of the files - Did a build locally and it worked (windows) - Running through try for other platforms now
Comment on attachment 585025 [details] [diff] [review] Folded. Patch v1. >--- a/accessible/accessible-docs.html >+++ b/accessible/accessible-docs.html > our case, this event is received in <a >- href="http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsWindow.cpp#4370">mozilla/widget/src/windows/nsWindow.cpp</a>. >+ href="http://lxr.mozilla.org/seamonkey/source/widget/windows/nsWindow.cpp#4370">mozilla/widget/windows/nsWindow.cpp</a>. Want to make this point to m-c? The seamonkey tree is apparently used only by bugzilla. >--- a/widget/src/windows/tests/Makefile.in >+++ b/widget/windows/tests/Makefile.in >+# XXX None of these stuff works in libxul builds. I say it's time to remove it, then!
It looks like some files in widget/(src/)windows/tests/ got their line ending convention changed; I don't know if that's desirable. Please also move the contents of widget/public up one, per comments 2 and 3. It would probably be clearest to do this in a second patch (also in this bug, however).
> It looks like some files in widget/(src/)windows/tests/ got their line ending > convention changed; I don't know if that's desirable. That was on purpose since those files end with windows line endings currently (CRLF) and it should be unix line endings (LF). > Please also move the contents of widget/public up one, per comments 2 and 3. > It would probably be clearest to do this in a second patch > (also in this bug, however). Will do regarding the widget/public.
I'll leave the following to another bug by the way, please post a new bug with specifics. > > --- a/widget/src/windows/tests/Makefile.in > > +++ b/widget/windows/tests/Makefile.in > > +# XXX None of these stuff works in libxul builds. > I say it's time to remove it, then!
- Now also folded /widget/public into /widget - Fixed URL to point to mozilla-central instead. The last try result succeeded by the way but I'm re-pushing to try with the new changes before requesting review.
Attachment #585025 - Attachment is obsolete: true
try run looks good: https://tbpl.mozilla.org/?tree=Try&rev=c56aeade4b48
Attachment #585322 - Flags: review?(roc) → review+
Pushed to mozilla-inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/e57e271bf328
Target Milestone: --- → mozilla12
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.