Closed
Bug 679226
Opened 13 years ago
Closed 12 years ago
Fold widget/src/ into widget/
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: bbondy, Assigned: bbondy)
References
Details
(Whiteboard: [not-fennec-11])
Attachments
(1 file, 1 obsolete file)
189.18 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
The contents of widget/src into belong in widget.
Assignee | ||
Comment 1•13 years ago
|
||
The above line should read: The contents of widget/src belong in widget/
Assignee | ||
Updated•13 years ago
|
Assignee: netzen → nobody
Component: Widget: Win32 → Widget
QA Contact: win32 → general
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → netzen
Comment 2•13 years ago
|
||
Should we also move the contents of widget/public up one? If so, it would make sense to do it in this bug.
Yeah
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Comment 4•12 years ago
|
||
Running through try before requesting review. Changes: - Folded widget/src into widget - Adjusted relative paths in Makefile.in files - Did a :%s/widget\/src/widget\//g in the rest of the files - Did a build locally and it worked (windows) - Running through try for other platforms now
Comment 5•12 years ago
|
||
Comment on attachment 585025 [details] [diff] [review] Folded. Patch v1. >--- a/accessible/accessible-docs.html >+++ b/accessible/accessible-docs.html > our case, this event is received in <a >- href="http://lxr.mozilla.org/seamonkey/source/widget/src/windows/nsWindow.cpp#4370">mozilla/widget/src/windows/nsWindow.cpp</a>. >+ href="http://lxr.mozilla.org/seamonkey/source/widget/windows/nsWindow.cpp#4370">mozilla/widget/windows/nsWindow.cpp</a>. Want to make this point to m-c? The seamonkey tree is apparently used only by bugzilla. >--- a/widget/src/windows/tests/Makefile.in >+++ b/widget/windows/tests/Makefile.in >+# XXX None of these stuff works in libxul builds. I say it's time to remove it, then!
Comment 6•12 years ago
|
||
Also, widget/public?
Comment 7•12 years ago
|
||
It looks like some files in widget/(src/)windows/tests/ got their line ending convention changed; I don't know if that's desirable. Please also move the contents of widget/public up one, per comments 2 and 3. It would probably be clearest to do this in a second patch (also in this bug, however).
Assignee | ||
Comment 8•12 years ago
|
||
> It looks like some files in widget/(src/)windows/tests/ got their line ending > convention changed; I don't know if that's desirable. That was on purpose since those files end with windows line endings currently (CRLF) and it should be unix line endings (LF). > Please also move the contents of widget/public up one, per comments 2 and 3. > It would probably be clearest to do this in a second patch > (also in this bug, however). Will do regarding the widget/public.
Assignee | ||
Comment 9•12 years ago
|
||
I'll leave the following to another bug by the way, please post a new bug with specifics. > > --- a/widget/src/windows/tests/Makefile.in > > +++ b/widget/windows/tests/Makefile.in > > +# XXX None of these stuff works in libxul builds. > I say it's time to remove it, then!
Assignee | ||
Comment 10•12 years ago
|
||
- Now also folded /widget/public into /widget - Fixed URL to point to mozilla-central instead. The last try result succeeded by the way but I'm re-pushing to try with the new changes before requesting review.
Attachment #585025 -
Attachment is obsolete: true
Assignee | ||
Comment 11•12 years ago
|
||
try run looks good: https://tbpl.mozilla.org/?tree=Try&rev=c56aeade4b48
Assignee | ||
Updated•12 years ago
|
Attachment #585322 -
Flags: review?(roc)
Attachment #585322 -
Flags: review?(roc) → review+
Assignee | ||
Comment 12•12 years ago
|
||
Pushed to mozilla-inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/e57e271bf328
Target Milestone: --- → mozilla12
Comment 13•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e57e271bf328
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [not-fennec-11]
You need to log in
before you can comment on or make changes to this bug.
Description
•