679229 - Links to reports list from Firefox 6.0 topcrashers not working

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Laura Thomson :laura]

https://crash-stats.mozilla.com/topcrasher/byversion/Firefox/6.0/7

The first rew non-empty sigs don't return anything, e.g.
https://crash-stats.mozilla.com/report/list?range_value=7&range_unit=days&date=2011-08-14&signature=vksaver3.dll%400x2e55&version=Firefox%3A6.0

Comment 1

[Robert Helmer [:rhelmer]]

I suspect this is a dup of bug 679065, but will test this.

Comment 2

[Laura Thomson :laura]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> I suspect this is a dup of bug 679065, but will test this.

I did think about commenting there, but wasn't sure.  Feel free to dup.

Comment 3

[Robert Helmer [:rhelmer]]

I am wrong and it's not a dup, but I think it's a problem with new TCBS aggregation. There are no entries for that signature in reports table:

---
breakpad=> SELECT count(*) FROM reports WHERE signature = 'vksaver3.dll@0x2e55' AND release_channel = 'release' AND product = 'Firefox' AND version = '6.0';
 count 
-------
     0
(1 row)
---

In summary, we haven't received any crash reports for this signature and Firefox 6.0 on release channel ever, so this should not be in the topcrasher list.

Comment 4

[Robert Helmer [:rhelmer]]

(In reply to Robert Helmer [:rhelmer] from comment #3)
> I am wrong and it's not a dup, but I think it's a problem with new TCBS
> aggregation. There are no entries for that signature in reports table:
> 
> ---
> breakpad=> SELECT count(*) FROM reports WHERE signature =
> 'vksaver3.dll@0x2e55' AND release_channel = 'release' AND product =
> 'Firefox' AND version = '6.0';
>  count 
> -------
>      0
> (1 row)
> ---
> 
> In summary, we haven't received any crash reports for this signature and
> Firefox 6.0 on release channel ever, so this should not be in the topcrasher
> list.

Actually I take that back, this is a bug in /report/list ... I forgot that we are supposed to be aggregating anything not beta, nightly, aurora as release (this seems wrong but is the old behavior so we'll go with it).

Josh pointed this out to me, but I glossed over it. This should be trivial to fix fortunately.

Comment 5

[Robert Helmer [:rhelmer]]

Attachment: look for release_channel not in ('aurora','nightly','beta'), not = 'release'

I also put "release" in an "else if", hopefully that makes it clearer what is happening here (I expect this to be confusing once everything goes to "new" tcbs)

Comment 6

[Lonnen :lonnen]

Comment on attachment 553344 [details] [diff] [review]
look for release_channel not in ('aurora','nightly','beta'), not = 'release'

Ran the following to compare to the webapp output following the patch:

select id, client_crash_date from reports where signature = 'vksaver3.dll@0x2e55' and release_channel not in ('aurora', 'nightly', 'beta')  and product = 'Firefox' AND version = '6.0' order by client_crash_date;

It found 47 rows. The webapp finds 45, but runs a slightly different query with date range cutoffs (http://rhelmer.pastebin.mozilla.org/1301642). 2 of the crashes get cut off by the date range, so it looks like the UI is displaying what we expect. r+

Comment 7

[Robert Helmer [:rhelmer]]

Landed on trunk:
Committed revision 3450.

Landed on 2.2 branch:
Committed revision 3451.

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Will test on https://crash-stats.allizom.org/topcrasher/byversion/Firefox/6.0/7 once staging updates, and report back (dinner, first!)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.allizom.org/topcrasher/byversion/Firefox/6.0/7/all?format=%2527, by following spot-checked links and ensuring they return data properly -- I checked the various "# of days" options, too.