Closed Bug 679251 Opened 8 years ago Closed 8 years ago

InlineReturn should advance the pc always

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: luke, Assigned: luke)

Details

Crash Data

Attachments

(1 file)

Attached patch fixSplinter Review
Asserting regs.sp == regs.fp->base() + js_ReconstructStackDepth in js_InternalThrow revealed a few cases where sp doesn't match pc.  I suspect this is causing the slow trickle of CrashIfInvalidSlot crashes (e.g. http://crash-stats.mozilla.com/report/index/bb39c9bf-bb35-4567-bbfe-64c742110809).
Attachment #553340 - Flags: review?(dvander)
Summary: InlienReturn should advance the pc always → InlineReturn should advance the pc always
Crash Signature: [@ CrashIfInvalidSlot ]
Attachment #553340 - Flags: review?(dvander) → review+
Hrm, I meant for this to go out with aurora but I doubt there will be an m-i -> m-c merge in the next 2 hours.  I guess I'll land on m-c and hopefully 3-way merge should avoid any merge pain.  Apologies to the m-i sheriff for the bother.

http://hg.mozilla.org/mozilla-central/rev/9967f28c64e1
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/604271b95a33
Target Milestone: --- → mozilla9
Target Milestone: mozilla9 → mozilla8
You need to log in before you can comment on or make changes to this bug.