Last Comment Bug 679251 - InlineReturn should advance the pc always
: InlineReturn should advance the pc always
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla8
Assigned To: Luke Wagner [:luke]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-15 18:54 PDT by Luke Wagner [:luke]
Modified: 2011-09-10 15:43 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (2.88 KB, patch)
2011-08-15 18:54 PDT, Luke Wagner [:luke]
dvander: review+
Details | Diff | Splinter Review

Description Luke Wagner [:luke] 2011-08-15 18:54:49 PDT
Created attachment 553340 [details] [diff] [review]
fix

Asserting regs.sp == regs.fp->base() + js_ReconstructStackDepth in js_InternalThrow revealed a few cases where sp doesn't match pc.  I suspect this is causing the slow trickle of CrashIfInvalidSlot crashes (e.g. http://crash-stats.mozilla.com/report/index/bb39c9bf-bb35-4567-bbfe-64c742110809).
Comment 2 Luke Wagner [:luke] 2011-08-16 09:27:38 PDT
Hrm, I meant for this to go out with aurora but I doubt there will be an m-i -> m-c merge in the next 2 hours.  I guess I'll land on m-c and hopefully 3-way merge should avoid any merge pain.  Apologies to the m-i sheriff for the bother.

http://hg.mozilla.org/mozilla-central/rev/9967f28c64e1

Note You need to log in before you can comment on or make changes to this bug.