Closed Bug 679261 Opened 8 years ago Closed 8 years ago
_stream _get _min _write returns frames but caller expects samples
sa_stream_get_min_write returns the result of snd_pcm_sw_params_get_start_threshold, which is reported in frames. nsAudioStream::GetMinWriteSamples and its callers expect the result in samples. The rest of sydneyaudio's API actually works in bytes, so to fix this sa_stream_get_min_write will be modified to report the result in bytes, and nsAudioStream can then convert that to a sample count.
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #553358 - Flags: review?(chris)
Forgot to qref part of the patch.
Attachment #553359 - Flags: review?(chris) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.