sa_stream_get_min_write returns frames but caller expects samples

RESOLVED FIXED in mozilla9

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: kinetik, Assigned: kinetik)

Tracking

Trunk
mozilla9
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
sa_stream_get_min_write returns the result of snd_pcm_sw_params_get_start_threshold, which is reported in frames.  nsAudioStream::GetMinWriteSamples and its callers expect the result in samples.

The rest of sydneyaudio's API actually works in bytes, so to fix this sa_stream_get_min_write will be modified to report the result in bytes, and nsAudioStream can then convert that to a sample count.
(Assignee)

Comment 1

6 years ago
Created attachment 553358 [details] [diff] [review]
patch v0
Assignee: nobody → kinetik
Status: NEW → ASSIGNED
Attachment #553358 - Flags: review?(chris)
(Assignee)

Comment 2

6 years ago
Created attachment 553359 [details] [diff] [review]
patch v0.1

Forgot to qref part of the patch.
Attachment #553358 - Attachment is obsolete: true
Attachment #553358 - Flags: review?(chris)
Attachment #553359 - Flags: review?(chris)
Attachment #553359 - Flags: review?(chris) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/5a4ca4d59be4
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/5a4ca4d59be4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.