Closed
Bug 679261
Opened 15 years ago
Closed 15 years ago
sa_stream_get_min_write returns frames but caller expects samples
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: kinetik, Assigned: kinetik)
Details
(Whiteboard: [inbound])
Attachments
(1 file, 1 obsolete file)
|
12.48 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
sa_stream_get_min_write returns the result of snd_pcm_sw_params_get_start_threshold, which is reported in frames. nsAudioStream::GetMinWriteSamples and its callers expect the result in samples.
The rest of sydneyaudio's API actually works in bytes, so to fix this sa_stream_get_min_write will be modified to report the result in bytes, and nsAudioStream can then convert that to a sample count.
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Comment 2•15 years ago
|
||
Forgot to qref part of the patch.
Attachment #553358 -
Attachment is obsolete: true
Attachment #553358 -
Flags: review?(chris)
Attachment #553359 -
Flags: review?(chris)
|
||
Updated•15 years ago
|
Attachment #553359 -
Flags: review?(chris) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•