js/src/jsdbgapi.cpp:1233: warning: ‘void UnsafeError(const char*, ...)’ defined but not used

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla9
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Another GCC warning snuck in. Introduced by jsdbg2, probably.
(Assignee)

Comment 1

6 years ago
Created attachment 553475 [details] [diff] [review]
v1

_GNU_SOURCE is a way for *programs* to specify which signatures they want[1] from GNU system headers that... anyway, it's not what you want here.

The compiler's preprocessor badge is __GNUC__.

[1] ...or something? if you care, read on:
    http://www.gnu.org/s/hello/manual/libc/Feature-Test-Macros.html
Assignee: general → jorendorff
Attachment #553475 - Flags: review?(sphink)
(Assignee)

Comment 2

6 years ago
I forgot to mention, in case the war room is reading along here: it turns out
jsdbg2 is innocent! In fact, it's perfect in every way. Please don't back it out.
:)

Updated

6 years ago
Attachment #553475 - Flags: review?(sphink) → review+
(Assignee)

Comment 3

6 years ago
hg.mozilla.org/integration/mozilla-inbound/rev/47ae156df73f
Whiteboard: [inbound]
The above link describes _GNU_SOURCE, but I needed to continue my edumification at http://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html

I think I knew this, but did a lazy grep for "GNU" and grabbed the first thing that looked relevant.

Thanks for the cleanup.
http://hg.mozilla.org/mozilla-central/rev/47ae156df73f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.