679346 - js/src/jsdbgapi.cpp:1233: warning: ‘void UnsafeError(const char*, ...)’ defined but not used

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Another GCC warning snuck in. Introduced by jsdbg2, probably.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

_GNU_SOURCE is a way for *programs* to specify which signatures they want[1] from GNU system headers that... anyway, it's not what you want here.

The compiler's preprocessor badge is __GNUC__.

[1] ...or something? if you care, read on:
    http://www.gnu.org/s/hello/manual/libc/Feature-Test-Macros.html

Comment 2

[Jason Orendorff [:jorendorff]]

I forgot to mention, in case the war room is reading along here: it turns out
jsdbg2 is innocent! In fact, it's perfect in every way. Please don't back it out.
:)

Comment 3

[Jason Orendorff [:jorendorff]]

hg.mozilla.org/integration/mozilla-inbound/rev/47ae156df73f

Comment 4

[Steve Fink [:sfink] [:s:]]

The above link describes _GNU_SOURCE, but I needed to continue my edumification at http://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html

I think I knew this, but did a lazy grep for "GNU" and grabbed the first thing that looked relevant.

Thanks for the cleanup.

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/47ae156df73f