679364 - Use either content/devtools/* or content/browser/devtools/* for aliases

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Dolske's comment from bug 582596:

::: browser/devtools/jar.mn
@@ +1,5 @@
>  browser.jar:
>      content/browser/NetworkPanel.xhtml            (webconsole/NetworkPanel.xhtml)
>  *   content/browser/scratchpad.xul                (scratchpad/scratchpad.xul)
>  *   content/browser/scratchpad.js                 (scratchpad/scratchpad.js)
> +    content/browser/csshtmltree.xhtml             (styleinspector/csshtmltree.xhtml)

I'd suggest having a "devtools" namespace here too. Either
content/devtools/* or content/browser/devtools/*.

Comment 1

[Rob Campbell [:rc] (:robcee)]

looks like:

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/jar.mn

still has some non-devtools-prefixed stuff. Would be good to get these cleaned up.

Making this a good first bug.

Comment 2

[AL]

I'm looking to get involved with Mozilla. Should I start working on this bug? Also, a little bit more of an explanation would be helpful.

Thanks!

Comment 3

[Rob Campbell [:rc] (:robcee)]

this is still a bug.

AL, it would be great if you could help out with this. Miker should be able to get you rolling on it.

Comment 4

[Brandon Benvie [:benvie]]

I'm going to go ahead and take this.

Comment 5

[Brandon Benvie [:benvie]]

Attachment: Use "content/browser/devtools/*" for aliases

Comment 6

[Victor Porof [:vporof][:vp]]

(In reply to Brandon Benvie [:bbenvie] from comment #5)
> Created attachment 716524 [details] [diff] [review]
> Use "content/browser/devtools/*" for aliases

Thank you so much for aligning everything in jar.mn. It was driving me crazy!

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 716524 [details] [diff] [review]
Use "content/browser/devtools/*" for aliases

Review of attachment 716524 [details] [diff] [review]:
-----------------------------------------------------------------

looks good!

(and yes. aligning jar.mn was properly righteous)

Comment 8

[Brandon Benvie [:benvie]]

Alignment is an utmost priority!

Comment 9

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/824b68f13f30

Comment 10

[Brandon Benvie [:benvie]]

Attachment: Use "content/browser/devtools/*" for aliases -- updated

Fixes the regression where one reference to profiler.xul was missed.

Comment 11

[Rob Campbell [:rc] (:robcee)]

backed out in:

https://hg.mozilla.org/integration/fx-team/rev/98bb8bc5c30b

congrats Brandon! First backout!

Comment 12

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 717972 [details] [diff] [review]
Use "content/browser/devtools/*" for aliases -- updated

Need one additional change in ProfilerPanel.jsm, line 58:

  this.iframe.setAttribute("src", "cleopatra.html?" + uid);

(remove devtools/ since we're already at the same relative depth).

Comment 13

[Paul Rouget [:paul]]

Any update on that?

Comment 14

[Brandon Benvie [:benvie]]

Can't believe I missed this.

Comment 15

[Victor Porof [:vporof][:vp]]

How's this looking? Can we land it?

Comment 16

[Brandon Benvie [:benvie]]

Attachment: WIP3

Finally got back to this. https://tbpl.mozilla.org/?tree=Try&rev=08504b940ae5

Comment 17

[Brandon Benvie [:benvie]]

Looks like all the failures are from other intermittent crashers.

Comment 18

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/4a068034be50

Comment 19

[Girish Sharma [:Optimizer]]

This is not resolved fixed yet :)

Comment 20

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/4a068034be50

Comment 21

[Jorge Villalobos [:jorgev] (he/him)]

This has minor add-on compatibility implications, and has been documented already: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23#Firefox_Developer_Tools