Use either content/devtools/* or content/browser/devtools/* for aliases

RESOLVED FIXED in Firefox 23

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: miker, Assigned: benvie)

Tracking

({addon-compat, dev-doc-complete})

unspecified
Firefox 23
addon-compat, dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe])

Attachments

(1 attachment, 2 obsolete attachments)

Dolske's comment from bug 582596:

::: browser/devtools/jar.mn
@@ +1,5 @@
>  browser.jar:
>      content/browser/NetworkPanel.xhtml            (webconsole/NetworkPanel.xhtml)
>  *   content/browser/scratchpad.xul                (scratchpad/scratchpad.xul)
>  *   content/browser/scratchpad.js                 (scratchpad/scratchpad.js)
> +    content/browser/csshtmltree.xhtml             (styleinspector/csshtmltree.xhtml)

I'd suggest having a "devtools" namespace here too. Either
content/devtools/* or content/browser/devtools/*.
looks like:

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/jar.mn

still has some non-devtools-prefixed stuff. Would be good to get these cleaned up.

Making this a good first bug.
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe]

Comment 2

5 years ago
I'm looking to get involved with Mozilla. Should I start working on this bug? Also, a little bit more of an explanation would be helpful.

Thanks!
this is still a bug.

AL, it would be great if you could help out with this. Miker should be able to get you rolling on it.
(Assignee)

Comment 4

5 years ago
I'm going to go ahead and take this.
(Assignee)

Updated

5 years ago
Assignee: nobody → bbenvie
(Assignee)

Comment 5

5 years ago
Created attachment 716524 [details] [diff] [review]
Use "content/browser/devtools/*" for aliases
Attachment #716524 - Flags: review?(rcampbell)
(In reply to Brandon Benvie [:bbenvie] from comment #5)
> Created attachment 716524 [details] [diff] [review]
> Use "content/browser/devtools/*" for aliases

Thank you so much for aligning everything in jar.mn. It was driving me crazy!
Comment on attachment 716524 [details] [diff] [review]
Use "content/browser/devtools/*" for aliases

Review of attachment 716524 [details] [diff] [review]:
-----------------------------------------------------------------

looks good!

(and yes. aligning jar.mn was properly righteous)
Attachment #716524 - Flags: review?(rcampbell) → review+
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe] → [good-first-bugs][lang=js][mentor=mikeratcliffe][land-in-fx-team]
(Assignee)

Comment 8

5 years ago
Alignment is an utmost priority!

Comment 9

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/824b68f13f30
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe][land-in-fx-team] → [good-first-bugs][lang=js][mentor=mikeratcliffe][fixed-in-fx-team]
(Assignee)

Comment 10

5 years ago
Created attachment 717972 [details] [diff] [review]
Use "content/browser/devtools/*" for aliases -- updated

Fixes the regression where one reference to profiler.xul was missed.
Attachment #716524 - Attachment is obsolete: true
Attachment #717972 - Flags: review?(rcampbell)
backed out in:

https://hg.mozilla.org/integration/fx-team/rev/98bb8bc5c30b

congrats Brandon! First backout!
Comment on attachment 717972 [details] [diff] [review]
Use "content/browser/devtools/*" for aliases -- updated

Need one additional change in ProfilerPanel.jsm, line 58:

  this.iframe.setAttribute("src", "cleopatra.html?" + uid);

(remove devtools/ since we're already at the same relative depth).
Attachment #717972 - Flags: review?(rcampbell)

Updated

5 years ago
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe][fixed-in-fx-team] → [good-first-bugs][lang=js][mentor=mikeratcliffe]

Comment 13

4 years ago
Any update on that?
(Assignee)

Comment 14

4 years ago
Can't believe I missed this.
Status: NEW → ASSIGNED
How's this looking? Can we land it?
(Assignee)

Comment 16

4 years ago
Created attachment 743766 [details] [diff] [review]
WIP3

Finally got back to this. https://tbpl.mozilla.org/?tree=Try&rev=08504b940ae5
Attachment #717972 - Attachment is obsolete: true
(Assignee)

Comment 17

4 years ago
Looks like all the failures are from other intermittent crashers.
(Assignee)

Updated

4 years ago
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe] → [good-first-bugs][lang=js][mentor=mikeratcliffe][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/4a068034be50
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe][land-in-fx-team] → [good-first-bugs][lang=js][mentor=mikeratcliffe][fixed-in-fx-team]
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
This is not resolved fixed yet :)
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
https://hg.mozilla.org/mozilla-central/rev/4a068034be50
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bugs][lang=js][mentor=mikeratcliffe][fixed-in-fx-team] → [good-first-bugs][lang=js][mentor=mikeratcliffe]
Target Milestone: --- → Firefox 23
This has minor add-on compatibility implications, and has been documented already: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/23#Firefox_Developer_Tools
Keywords: addon-compat, dev-doc-complete
You need to log in before you can comment on or make changes to this bug.