679486 - Create some BMP reftests for OS/2 bitmaps

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Brian R. Bondy [:bbondy]]

We have very good coverage of BMP decoders via Bug 600556, but not yet any coverage for OS/2 bitmaps.  These are bitmaps with an information header of 12 bytes instead of 40 bytes. 

We should have support for OS2 bitmaps for Bit per pixels
- 1
- 4
- 8 
- 24

Since OS/2 bitmaps do not have compression, we should only need the basic equivalent tests for our current coverage.

I can't seem to find an image editing software that allows you to encode in a specific way for OS/2 bitmaps but what I will do is use a hex editor to manually generate the input test OS/2 bitmap headers, and use the equivalent data from the normal BMP handling code.   After making sure with other programs that they are correct I will implement the reftests.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: REftests for OS/2 BMPs

Since just the Bitmap Information Header changes, and the color table changes, but not the data handling for OS/2 bitmaps vs MS bitmaps.  I did just one ref test per Bit Per Pixel value.  

I also did a test for an invalid OS/2 Bit Per Pixel value.

I did these ref tests because I wanted to be sure that my BMP refactoring did not cause any regressions and that we had proper handling in general for OS/2 bitmaps.

Comment 2

[Brian R. Bondy [:bbondy]]

Pushed to mozilla-inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/db59a3f2f661

Comment 3

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/db59a3f2f661