Last Comment Bug 679486 - Create some BMP reftests for OS/2 bitmaps
: Create some BMP reftests for OS/2 bitmaps
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: Trunk
: x86_64 All
-- normal (vote)
: mozilla9
Assigned To: Brian R. Bondy [:bbondy]
: Milan Sreckovic [:milan]
Depends on: 600556
Blocks: 679725
  Show dependency treegraph
Reported: 2011-08-16 13:42 PDT by Brian R. Bondy [:bbondy]
Modified: 2011-09-01 01:37 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

REftests for OS/2 BMPs (10.49 KB, patch)
2011-08-17 08:37 PDT, Brian R. Bondy [:bbondy]
joe: review+
Details | Diff | Splinter Review

Description User image Brian R. Bondy [:bbondy] 2011-08-16 13:42:27 PDT
We have very good coverage of BMP decoders via Bug 600556, but not yet any coverage for OS/2 bitmaps.  These are bitmaps with an information header of 12 bytes instead of 40 bytes. 

We should have support for OS2 bitmaps for Bit per pixels
- 1
- 4
- 8 
- 24

Since OS/2 bitmaps do not have compression, we should only need the basic equivalent tests for our current coverage.

I can't seem to find an image editing software that allows you to encode in a specific way for OS/2 bitmaps but what I will do is use a hex editor to manually generate the input test OS/2 bitmap headers, and use the equivalent data from the normal BMP handling code.   After making sure with other programs that they are correct I will implement the reftests.
Comment 1 User image Brian R. Bondy [:bbondy] 2011-08-17 08:37:07 PDT
Created attachment 553787 [details] [diff] [review]
REftests for OS/2 BMPs

Since just the Bitmap Information Header changes, and the color table changes, but not the data handling for OS/2 bitmaps vs MS bitmaps.  I did just one ref test per Bit Per Pixel value.  

I also did a test for an invalid OS/2 Bit Per Pixel value.

I did these ref tests because I wanted to be sure that my BMP refactoring did not cause any regressions and that we had proper handling in general for OS/2 bitmaps.
Comment 2 User image Brian R. Bondy [:bbondy] 2011-08-31 07:45:09 PDT
Pushed to mozilla-inbound:
Comment 3 User image Ed Morley [:emorley] 2011-09-01 01:37:47 PDT

Note You need to log in before you can comment on or make changes to this bug.