Closed Bug 679590 Opened 14 years ago Closed 13 years ago

Intermittent failure in browser_607016.js | sanity check that tab doesn't have extData

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 10

People

(Reporter: philor, Assigned: zpao)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

http://tbpl.allizom.org/php/getParsedLog.php?id=5994132 Rev3 Fedora 12x64 mozilla-central opt test mochitest-other on 2011-08-16 12:58:41 PDT for push 9967f28c64e1 TEST-PASS | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_607016.js | sanity check that tab has correct extData TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_607016.js | sanity check that tab doesn't have extData
OS: Linux → All
Hardware: x86_64 → All
Just adding an info(tabstate) to figure out what's in the current state that shouldn't be.
https://tbpl.mozilla.org/php/getParsedLog.php?id=6977616&tree=Fx-Team#error0 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_607016.js | sanity check that tab doesn't have extData Stack trace: JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_607016.js :: progressCallback :: line 94 JS frame :: chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_607016.js :: <TOP_LEVEL> :: line 67 JS frame :: chrome://browser/content/tabbrowser.xml :: <TOP_LEVEL> :: line 426 JS frame :: chrome://browser/content/tabbrowser.xml :: _callProgressListeners :: line 423 JS frame :: chrome://browser/content/tabbrowser.xml :: <TOP_LEVEL> :: line 470 JS frame :: chrome://browser/content/tabbrowser.xml :: <TOP_LEVEL> :: line 595 TEST-INFO | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_607016.js | tabState: {"entries":[{"url":"http://example.org#6"}],"hidden":false,"extData":{"tabview-tab":"{\"url\":\"http://example.org/#6\",\"groupID\":62,\"title\":\"http://example.org#6\"}"}}
So it turns out that Panorama had been used on that window and was re-setting data into extdata before we did our check. That's a totally legit case, just not one I was expecting when I wrote the test. So I fixed the test to be more specific for what it's checking - if there is extdata when our defined state didn't expect it, we check more specifically to make sure that we don't have the key that the other tabs should have.
Assignee: nobody → paul
Attachment #569143 - Flags: review?(dietrich)
Attachment #569143 - Flags: review?(dietrich) → review+
I took the freedom to land the patch since I just saw a couple of these oranges https://hg.mozilla.org/integration/mozilla-inbound/rev/a414fc0d982b (sorry for broken chars in name, likely I should have used hgencoding=utf-8 option on the push)
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10