Closed
Bug 679615
Opened 14 years ago
Closed 14 years ago
Remove config/gtscc.c
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: david.volgyes, Assigned: matjk7)
References
Details
Attachments
(1 file)
|
63.18 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20100101 Firefox/6.0
Build ID: 20110812233755
Steps to reproduce:
cppcheck found some memory leak in gtscc.c.
Actual results:
These are the reported leaks:
[firefox-src/config/gtscc.c:764]: (error) Memory leak: source
[firefox-src/config/gtscc.c:764]: (error) Memory leak: object
[firefox-src/config/gtscc.c:1247]: (error) Memory leak: archive
[firefox-src/config/gtscc.c:2506]: (error) Memory leak: table
[firefox-src/config/gtscc.c:2506]: (error) Memory leak: dmap
Expected results:
You should release the objects before exit point.
However, these bugs are not too importants, because the itself a program, and the memory will be released, when the program ends.
|
||
Updated•14 years ago
|
Component: General → Build Config
QA Contact: general → build.config
|
||
Comment 1•14 years ago
|
||
There aren't even rules to build that program.
|
|
||
Comment 2•14 years ago
|
||
And the rules to do so have been removed in ... 1999.
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=Makefile.in&branch=3.26&root=/cvsroot&subdir=mozilla/config&command=DIFF_FRAMESET&rev1=3.25&rev2=3.26
|
||
Comment 3•14 years ago
|
||
Someone should just hg rm it.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: memory leaks in config/gtscc.c → Remove config/gtscc.c
|
|
||
Comment 4•14 years ago
|
||
and remove the reference in the packager.mk.
|
Reporter | |
Comment 5•14 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #1)
> There aren't even rules to build that program.
That highlights a drawback of cppcheck:
cppcheck does not use makefile (or other rule file), it is just scan all the source files, so it produces warning for unused files too.
Maybe a cleanup would be useful. Probably there are some other unused files in the trunk.
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #553969 -
Flags: review?(ted.mielczarek)
|
|
||
Updated•14 years ago
|
Assignee: nobody → matjk7
Status: NEW → ASSIGNED
|
|
||
Comment 7•14 years ago
|
||
Comment on attachment 553969 [details] [diff] [review]
patch
Review of attachment 553969 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #553969 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Updated•14 years ago
|
|
||
Comment 8•14 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → Firefox 9
|
|
||
Updated•14 years ago
|
Keywords: checkin-needed
|
|
||
Comment 9•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
|
||
Updated•7 years ago
|
Target Milestone: Firefox 9 → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•