679672 - "foo 42 bar" should not be parsed as "42" when reflecting an attribute of type long

Status: RESOLVED DUPLICATE of bug 673820

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Testcase:
data:text/html,<script>var i = document.createElement("input"); i.setAttribute("size", "foo 42 bar"); alert("attr: '" + i.size + "'");</script>

It should show "20", input.size default value. Instead, we show "42". Presto and Webkit show "0" but that's because they believe '0' is input.size default value.

Very likely, the reasons of this bug are close to bug 679671.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Right now we skip any leading non-numbers in nsAttrValue::StringToInteger.  What does the spec say to do for various integer-valued attributes instead?

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to Boris Zbarsky (:bz) from comment #1)
> Right now we skip any leading non-numbers in nsAttrValue::StringToInteger. 
> What does the spec say to do for various integer-valued attributes instead?

We should skip any leading non-numbers. That is what the specs require and other browsers do but that is not what we are doing. The code in nsAttrValue::StringToInteger seems to do that but ends up calling nsAutoString::ToInteger(). I would guess this method consider "foo 42 bar" to be the integer 42.

Actually, generally speaking, it's not really clear why we are calling nsAutoString::ToInteger() when the algorithm isn't able to find an integer. It seems to be a good way to not follow the specs.

FWIW, I think what the specs ask is close to what parseInt() does.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Uh, no. The spec want us to skip whitespace, not just any random junk. All random junk *at the end*, otoh, is ignored.

Comment 4

[Mounir Lamouri (:mounir)]

I don't know if you were replying to me or Boris but indeed leading whitespaces are ignored, it was without saying.

Comment 5

[Boris Zbarsky [:bzbarsky]]

So yes, sounds like we should change StringToInteger to bail out on finding non-whitespace non-numbers instead of pressing on.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I assume this will be fixed by bug 673820.