Closed Bug 679677 Opened 10 years ago Closed 10 years ago
Add more app
.update .certs .* possibilities to Sea Monkey
SeaMonkey currently only has one CA possibility for update: http://mxr.mozilla.org/comm-central/source/suite/browser/browser-prefs.js?mark=516-517#504 Firefox has two: http://mxr.mozilla.org/comm-central/source/mozilla/browser/app/profile/firefox.js?mark=136-137,139-140#124 We should add one or two in addition, so we have more freedom of where to get our certs from. Restricting them is good for security, but only one choice is bad again, giving us no possibilities to switch if one CA has a problem. fox2mike: Which CA(s) would Mozilla prefer us to add there? (Note that it will take quite some time until we have a so high audience on new versions that we could abandon the current one, but the sooner we introduce other pref values, the sooner we'll be actually able to have a choice.)
Patch against comm-release (will check shortly if it applies elsewhere)
Whops, missed a save point before refressing.
Comment on attachment 553771 [details] [diff] [review] v1.1 comm-release Yes, that seems fine. Can we build a test build with this setting, and test? I can switch the certs out, we can test and switch back. Would be a shame to put this in the code and ship without testing.
Attachment #553771 - Flags: feedback?(shyam) → feedback+
Comment on attachment 553771 [details] [diff] [review] v1.1 comm-release >+pref("app.update.certs.2.issuerName", 'CN=GeoTrust SSL CA,O="GeoTrust, Inc.",C=US'); Given the way we quote Thawte: >+pref("app.update.certs.3.issuerName", "CN=Thawte SSL CA,O=\"Thawte, Inc.\",C=US"); can you please go for the same style for GeoTrust? With that, let's land this on trunk, kick off nightlies with it and test them with the old and new certificates. Please also go through testing with and older build with manually adding those. Once that's done, please request approval for aurora/beta/release (I see that comm doesn't have a release approval tag, btw).
Attachment #553771 - Flags: review?(kairo) → review+
Landed: http://hg.mozilla.org/comm-central/rev/ff7b4aaace25 We'll test this tomorrow. Pre-requesting approvals.
Comment on attachment 553771 [details] [diff] [review] v1.1 comm-release rs=me assuming this tests out successfully.
Attachment #553771 - Flags: approval-seamonkey2.0.15?
Attachment #553771 - Flags: approval-seamonkey2.0.15+
Attachment #553771 - Flags: approval-comm-beta?
Attachment #553771 - Flags: approval-comm-beta+
Attachment #553771 - Flags: approval-comm-aurora?
Attachment #553771 - Flags: approval-comm-aurora+
http://hg.mozilla.org/releases/comm-release/rev/e058afbc7361 http://hg.mozilla.org/releases/comm-beta/rev/a0dbd46ca942 http://hg.mozilla.org/releases/comm-aurora/rev/6f5b341d84d1 Turns out we don't need this for 2.0.x (we don't actually check the cert this way there) I'll plan an extra aus test with the non-modified 2.0.x just to be safe.
Attachment #553771 - Flags: approval-seamonkey2.0.15+ → approval-seamonkey2.0.15-
You need to log in before you can comment on or make changes to this bug.