Comment 1 neil@parkwaycc.co.uk 2011-08-17 06:38:28 PDT

Created attachment 553748 [details]
WinDbg stack trace

Comment 2 neil@parkwaycc.co.uk 2011-08-17 06:44:15 PDT

Looks like they also set it to the empty string in script too...

Comment 3 Jesse Ruderman 2011-08-22 16:41:46 PDT

Created attachment 554988 [details]
testcase

Comment 4 Boris Zbarsky [:bz] (TPAC) 2011-08-23 22:18:00 PDT

nsAttrValue::SetMiscAtomOrString has this code:

    PRUint32 len = aValue->Length();
    // We're allowing eCSSStyleRule attributes to store empty strings as it
    // can be beneficial to store an empty style attribute as a parsed rule.
    // Add other types as needed.
    NS_ASSERTION(len || Type() == eCSSStyleRule, "Empty string?");

Jonas, sounds like we should add enumerated types here, right?

Comment 5 Jonas Sicking (:sicking) No longer reading bugmail consistently 2011-08-24 07:57:14 PDT

Yeah

Comment 6 Boris Zbarsky [:bz] (TPAC) 2011-08-24 11:56:30 PDT

Created attachment 555477 [details] [diff] [review]
Allow empty string values to be associtated to enumerated attributes.

Comment 7 Ed Morley [:emorley] 2011-08-31 17:05:22 PDT

Something in this push caused orange, so backed out of inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usebuildbot=1&rev=89b87e96dc17
http://hg.mozilla.org/integration/mozilla-inbound/rev/b449db7a038b

Comment 8 Boris Zbarsky [:bz] (TPAC) 2011-08-31 21:15:12 PDT

The orange was something else.  Pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/aa18f8632882

Comment 9 Ed Morley [:emorley] 2011-09-01 02:00:02 PDT

http://hg.mozilla.org/mozilla-central/rev/aa18f8632882