679689 - ASSERTION: Empty string? trying to parse HTML image with empty crossorigin attribute

Status: RESOLVED FIXED

Description

[[e-mail]]

I hit this assertion and according to the local variables on the stack the SetAttr in question has a name of "crossorigin" and an empty value.

Comment 1

[[e-mail]]

Created attachment 553748 [details]
WinDbg stack trace

Comment 2

[[e-mail]]

Looks like they also set it to the empty string in script too...

Comment 3

[Jesse Ruderman]

Created attachment 554988 [details]
testcase

Comment 4

[Boris Zbarsky [:bz]]

nsAttrValue::SetMiscAtomOrString has this code:

    PRUint32 len = aValue->Length();
    // We're allowing eCSSStyleRule attributes to store empty strings as it
    // can be beneficial to store an empty style attribute as a parsed rule.
    // Add other types as needed.
    NS_ASSERTION(len || Type() == eCSSStyleRule, "Empty string?");

Jonas, sounds like we should add enumerated types here, right?

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yeah

Comment 6

[Boris Zbarsky [:bz]]

Created attachment 555477 [details] [diff] [review]
Allow empty string values to be associtated to enumerated attributes.

Comment 7

[Ed Morley [:emorley]]

Something in this push caused orange, so backed out of inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usebuildbot=1&rev=89b87e96dc17
http://hg.mozilla.org/integration/mozilla-inbound/rev/b449db7a038b

Comment 8

[Boris Zbarsky [:bz]]

The orange was something else.  Pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/aa18f8632882

Comment 9

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/aa18f8632882