The default bug view has changed. See this FAQ.

ASSERTION: Empty string? trying to parse HTML image with empty crossorigin attribute

RESOLVED FIXED in mozilla9

Status

()

Core
DOM: Core & HTML
P1
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: bz)

Tracking

({assertion})

Trunk
mozilla9
x86
Windows 2000
assertion
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
I hit this assertion and according to the local variables on the stack the SetAttr in question has a name of "crossorigin" and an empty value.
(Reporter)

Comment 1

6 years ago
Created attachment 553748 [details]
WinDbg stack trace
(Reporter)

Comment 2

6 years ago
Looks like they also set it to the empty string in script too...

Comment 3

6 years ago
Created attachment 554988 [details]
testcase
nsAttrValue::SetMiscAtomOrString has this code:

    PRUint32 len = aValue->Length();
    // We're allowing eCSSStyleRule attributes to store empty strings as it
    // can be beneficial to store an empty style attribute as a parsed rule.
    // Add other types as needed.
    NS_ASSERTION(len || Type() == eCSSStyleRule, "Empty string?");

Jonas, sounds like we should add enumerated types here, right?
Yeah
Created attachment 555477 [details] [diff] [review]
Allow empty string values to be associtated to enumerated attributes.
Attachment #555477 - Flags: review?(jonas)
Assignee: nobody → bzbarsky
Priority: -- → P1
Whiteboard: [need review]
Attachment #555477 - Flags: review?(jonas) → review+
Whiteboard: [need review] → [need landing]
Something in this push caused orange, so backed out of inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&usebuildbot=1&rev=89b87e96dc17
http://hg.mozilla.org/integration/mozilla-inbound/rev/b449db7a038b
Whiteboard: [need landing]
The orange was something else.  Pushed http://hg.mozilla.org/integration/mozilla-inbound/rev/aa18f8632882
Flags: in-testsuite+
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/aa18f8632882
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.