Further Lion-ize Toolbar Icons

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Theme
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: shorlander, Assigned: shorlander)

Tracking

(Blocks: 1 bug, {addon-compat})

Trunk
Firefox 9
x86
Mac OS X
addon-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 553769 [details] [diff] [review]
Update Lion Glyphs - 01 WIP

To further Lion-ize the toolbar icons:

* Update style: lighter gradient and stronger inner shadow
* Update Library icons and tabstrip icons
* Disabled icons should be 60% opacity

* Inactive window:
  - Icons should be 60% opacity
  - Disabled icons should be 30% opacity
  - Have a hover 100% opacity hover state

The attached WIP patch updates the images but I am not sure if there is a way to make Lion specific CSS rules for the inactive window state?
Attachment #553769 - Flags: feedback?(mstange)
(Assignee)

Comment 1

6 years ago
Created attachment 553772 [details]
Patch Screenshot
Comment on attachment 553769 [details] [diff] [review]
Update Lion Glyphs - 01 WIP

Looks great!

(In reply to Stephen Horlander from comment #0)
> The attached WIP patch updates the images but I am not sure if there is a
> way to make Lion specific CSS rules for the inactive window state?

Not yet. I'll write a patch that adds :-moz-system-metric(mac-lion-theme).
Attachment #553769 - Flags: feedback?(mstange) → feedback+
Also, have you piped the images through an optimizer like ImageOptim?
(Assignee)

Comment 4

6 years ago
Created attachment 553776 [details]
Design Goal

Design for normal, disabled and inactive states
(Assignee)

Comment 5

6 years ago
(In reply to Markus Stange from comment #3)
> Also, have you piped the images through an optimizer like ImageOptim?

Yes, I used ImageOptim. 

> Not yet. I'll write a patch that adds :-moz-system-metric(mac-lion-theme).

Awesome, thank you!
Depends on: 679717
(Assignee)

Comment 6

6 years ago
Created attachment 554437 [details] [diff] [review]
Update Lion Glyphs - 02

Updated patch using -moz-mac-lion-theme for disabled and inactive-window rules. Also removed bookmarks and history checked hover:active state since it isn't used anymore
Attachment #553769 - Attachment is obsolete: true
Attachment #554437 - Flags: feedback?(mstange)
(Assignee)

Comment 7

6 years ago
Created attachment 554438 [details]
Patch Screenshot - 02
Attachment #553772 - Attachment is obsolete: true
Attachment #554437 - Flags: feedback?(mstange) → feedback+
(Assignee)

Updated

6 years ago
Attachment #554437 - Flags: review?(dao)
Comment on attachment 554438 [details]
Patch Screenshot - 02

The disabled state seems quite subtle (significantly more subtle than on Windows until recently, where people already complained). I guess I can only blame Apple for this?
(Assignee)

Comment 9

6 years ago
(In reply to Dão Gottwald [:dao] from comment #8)
> Comment on attachment 554438 [details]
> Patch Screenshot - 02
> 
> The disabled state seems quite subtle (significantly more subtle than on
> Windows until recently, where people already complained). I guess I can only
> blame Apple for this?

It is pretty subtle. The push towards less contrasty icons in Lion makes the available range for disabled more narrow.

We don't have to conform exactly however I don't think it will be confusing in the context of Lion. It is more obvious in use than in a screenshot.

Pushing the opacity down to .5 would make it more obvious and probably wouldn't look out of place.
Comment on attachment 554437 [details] [diff] [review]
Update Lion Glyphs - 02

Ok, I think we should use 50% opacity for the disabled state, or really any other value that gets us closer to 40% without alienating die-hard OS X enthusiasts.
Attachment #554437 - Flags: review?(dao) → review+
(Assignee)

Comment 11

6 years ago
Created attachment 555156 [details]
Patch Screenshot - 03

I changed the opacity to .5 here which is a small but noticeable improvement.
Attachment #554438 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/2392fc3ad758
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9

Updated

6 years ago
Assignee: nobody → shorlander
Blocks: 683414
Manifest overrides may break third party themes
Keywords: addon-compat
(In reply to Nils Maier [:nmaier] from comment #13)
> Manifest overrides may break third party themes

I wasn't aware of this. Please file a bug?
See bug 702558.
You need to log in before you can comment on or make changes to this bug.