The default bug view has changed. See this FAQ.

nsIFrame::IsFocusable incorrectly uses the absolute size of scrollbars to determine if a scrollable frame should be focusable

RESOLVED FIXED in mozilla9

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

(Blocks: 1 bug)

unspecified
mozilla9
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
In fennec, we don't show scrollbars, so content/events/test_bug409604.html fails when trying to focus a scrollable div.
(Assignee)

Comment 1

6 years ago
Created attachment 553835 [details] [diff] [review]
Make nsIFrame::IsFocusable use heuristics that don't depend on the graphical display of scrollbars.

Waiting on try results before requesting review.
(Assignee)

Updated

6 years ago
Blocks: 668283
(Assignee)

Comment 2

6 years ago
Comment on attachment 553835 [details] [diff] [review]
Make nsIFrame::IsFocusable use heuristics that don't depend on the graphical display of scrollbars.

Try looks like all known oranges. Boris, you reviewed a similar change for David Bolter, so you seem like a reasonable reviewer choice to me.
Attachment #553835 - Flags: review?(bzbarsky)
Comment on attachment 553835 [details] [diff] [review]
Make nsIFrame::IsFocusable use heuristics that don't depend on the graphical display of scrollbars.

Actually, I think roc should look at this one.  It's not clear to me whether this is the right way to test for "overflow:auto that actually overflows"...
Attachment #553835 - Flags: review?(bzbarsky) → review?(roc)
Comment on attachment 553835 [details] [diff] [review]
Make nsIFrame::IsFocusable use heuristics that don't depend on the graphical display of scrollbars.

Review of attachment 553835 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, I think this is what I would have written :-).
Attachment #553835 - Flags: review?(roc) → review+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/9e0f8a7cc1a0
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/9e0f8a7cc1a0
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.