Last Comment Bug 679801 - "New Tab", "Panorama" and "List All Tabs" buttons do not get inverted on Aero with tabs on bottom
: "New Tab", "Panorama" and "List All Tabs" buttons do not get inverted on Aero...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86 Windows 7
: -- normal (vote)
: Firefox 14
Assigned To: Joshua M [:soapy]
:
Mentors:
Depends on:
Blocks: 580194
  Show dependency treegraph
 
Reported: 2011-08-17 11:13 PDT by Sid
Modified: 2012-03-24 13:56 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
All buttons in a row on a glass toolbar (12.22 KB, image/png)
2011-08-17 11:13 PDT, Sid
no flags Details
Patch for 679801 v1 (4.55 KB, patch)
2011-09-02 15:48 PDT, Joshua M [:soapy]
no flags Details | Diff | Splinter Review
Patch v2 (4.34 KB, patch)
2012-03-22 19:44 PDT, Joshua M [:soapy]
dao+bmo: review+
Details | Diff | Splinter Review

Description Sid 2011-08-17 11:13:40 PDT
Created attachment 553842 [details]
All buttons in a row on a glass toolbar

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:9.0a1) Gecko/20110817 Firefox/9.0a1
Build ID: 20110817061121

Steps to reproduce:

1. Ensure you have tabs on bottom, so that navigation and menu toolbars are covered with Aero glass. Optionally enable small icons mode to allow inversion on navigation toolbar.
2. Move "New Tab", "Panorama" and "List All Tabs" buttons somewhere on the glass toolbar. Move some other buttons near them to compare inversion effect.


Actual results:

All buttons are inverted. "New Tab", "Panorama" and "List All Tabs" are not, and they are hardly visible against a dark background.


Expected results:

All buttons should get inverted.
Comment 1 Joshua M [:soapy] 2011-09-02 15:48:31 PDT
Created attachment 557973 [details] [diff] [review]
Patch for 679801 	v1

WIP patch for bug 679801
Comment 2 Joshua M [:soapy] 2012-03-22 19:44:48 PDT
Created attachment 608580 [details] [diff] [review]
Patch v2
Comment 4 Ed Morley [:emorley] 2012-03-24 13:56:55 PDT
https://hg.mozilla.org/mozilla-central/rev/04eded939558

Note You need to log in before you can comment on or make changes to this bug.