679938 - report whether firefox is the default browser

Status: RESOLVED WONTFIX

(Toolkit :: Telemetry, defect)

Comment 1

[(dormant account)]

Sid, this is ok with you, right?

Comment 2

[(dormant account)]

Attachment: defaultbrowser simple measurement

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 556719 [details] [diff] [review]
defaultbrowser simple measurement

Review of attachment 556719 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/telemetry/TelemetryPing.js
@@ +193,4 @@
>    var ret = {
>      // uptime in minutes
> +    uptime: Math.round((new Date() - si.process) / 60000),
> +    defaultBrowser: defaultBrowser * 1

I'd use Number(defaultBrowser) instead to make the intent clearer.

r=me with the above. As a bonus, I'd add a comma at the end of this line, so that further additions only require adding lines, and not modifying the previous one.

Comment 4

[Sid Stamm [:geekboy or :sstamm]]

Since bug 685373 landed, privacy review is resolved. 
https://wiki.mozilla.org/Privacy/Reviews/Telemetry/Default_Browser_Status

Comment 5

[Nathan Froyd [:froydnj]]

Assigning to Taras; would be nice to get this landed.

Comment 6

[(dormant account)]

We do not have a clear need for this.