possible use of uninitialized values in nsFontFaceLoader::LoadTimerCallback

RESOLVED FIXED in mozilla9

Status

()

Core
Layout: Text
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

({valgrind})

Trunk
mozilla9
valgrind
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 554022 [details] [diff] [review]
patch v1 - check calls for failure before using the results

In nsFontFaceLoader::LoadTimerCallback, we don't check the GetContentLength and GetNumBytesRead calls for success, which means that we may end up using uninitialized values (in the event one of these calls failed) when testing how far the download has progressed.

While this isn't a critical problem - the worst-case result is that we suppress fallback rendering for an extra 50% delay period - we should fix it to ensure more consistent behavior, as well as to avoid Valgrind complaints.
Attachment #554022 - Flags: review?(jdaggett)

Updated

6 years ago
Attachment #554022 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 1

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/d051bc49c304
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/d051bc49c304
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.