Closed Bug 680037 Opened 9 years ago Closed 9 years ago

possible use of uninitialized values in nsFontFaceLoader::LoadTimerCallback

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

(Keywords: valgrind)

Attachments

(1 file)

In nsFontFaceLoader::LoadTimerCallback, we don't check the GetContentLength and GetNumBytesRead calls for success, which means that we may end up using uninitialized values (in the event one of these calls failed) when testing how far the download has progressed.

While this isn't a critical problem - the worst-case result is that we suppress fallback rendering for an extra 50% delay period - we should fix it to ensure more consistent behavior, as well as to avoid Valgrind complaints.
Attachment #554022 - Flags: review?(jdaggett)
Attachment #554022 - Flags: review?(jdaggett) → review+
http://hg.mozilla.org/mozilla-central/rev/d051bc49c304
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.