680045 - Add elements to UI map for add-ons with EULA

Status: RESOLVED WONTFIX

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

We are currently dealing with two new UI elements for testing installation of an EULA add-on 

  var continueToDownloadLink = new elementslib.Selector(controller.window.document, ".install-action")'

  var acceptAndInstallButton = new elementslib.Selector(controller.window.document, ".install-button"); 

which are retrieved using elementslib.Selector. 

---------------------------------------------------------------------
I've agreed with Anthony that is best for these two elements to be added to the addons.js UI map 

Feel free to correct me otherwise.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Sounds fair. Can you come up with a patch, Vlad?

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

Right away

Comment 3

[Maniac Vlad Florin (:vladmaniac)]

just one thing: under which class do we want these two elements added? addonsManager? discoveryPane? the test installs the add-on from amo production 
because we cannot predict whether the disc pane can provide an EULA add-on. 

Henrik, what do you suggest?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Those are remote elements and have to be part of the discoveryPane class.

Comment 5

[Maniac Vlad Florin (:vladmaniac)]

If we add the elements to the discoveryPane class UI map we'll need to open the disc pane in our test to access the elements - we don't want that 

If we add the elements to the addonsManager class we fail at best practices because those are remote elements - we don't want that 

We'll keep those in the test, and this marks this bug as WONTFIX