I have misused NS_SUCCEEDED in bug 676401. This should be fixed ASAP.
Created attachment 554042 [details] [diff] [review]
I’m sorry, I had completely misunderstood what NS_SUCCEEDED was about. This patch should fix it, thanks Ms2ger for pointing out.
The test included in bug 676401 still applies (and passes).
Created attachment 554051 [details] [diff] [review]
One minute agot on #developers:
<Ms2ger> kaze, looks good, but I'd prefer if you used "rv"
instead of "res", like everyone outside editor/ does :)
So be it! :-)
Created attachment 554053 [details] [diff] [review]
sorry, forgot an `hg qrefresh' before uploading :-s