Last Comment Bug 680060 - [queryCommandEnabled] check `GetIsSelectionEditable' results
: [queryCommandEnabled] check `GetIsSelectionEditable' results
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla9
Assigned To: Fabien Cazenave [:kaze]
:
Mentors:
Depends on: 676401
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-18 05:40 PDT by Fabien Cazenave [:kaze]
Modified: 2011-08-19 03:12 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch proposal (7.29 KB, patch)
2011-08-18 05:46 PDT, Fabien Cazenave [:kaze]
no flags Details | Diff | Splinter Review
patch proposal (7.26 KB, patch)
2011-08-18 06:03 PDT, Fabien Cazenave [:kaze]
no flags Details | Diff | Splinter Review
patch proposal (7.26 KB, patch)
2011-08-18 06:05 PDT, Fabien Cazenave [:kaze]
ehsan: review+
Details | Diff | Splinter Review

Description Fabien Cazenave [:kaze] 2011-08-18 05:40:16 PDT
I have misused NS_SUCCEEDED in bug 676401. This should be fixed ASAP.
Comment 1 Fabien Cazenave [:kaze] 2011-08-18 05:46:52 PDT
Created attachment 554042 [details] [diff] [review]
patch proposal

Iā€™m sorry, I had completely misunderstood what NS_SUCCEEDED was about. This patch should fix it, thanks Ms2ger for pointing out.

The test included in bug 676401 still applies (and passes).
Comment 2 Fabien Cazenave [:kaze] 2011-08-18 06:03:05 PDT
Created attachment 554051 [details] [diff] [review]
patch proposal

One minute agot on #developers:

   <Ms2ger> kaze, looks good, but I'd prefer if you used "rv"
            instead of "res", like everyone outside editor/ does :)   

So be it! :-)
Comment 3 Fabien Cazenave [:kaze] 2011-08-18 06:05:07 PDT
Created attachment 554053 [details] [diff] [review]
patch proposal

sorry, forgot an `hg qrefresh' before uploading :-s
Comment 4 Marco Bonardo [::mak] 2011-08-19 03:12:02 PDT
http://hg.mozilla.org/mozilla-central/rev/fae3f1a9327b

Note You need to log in before you can comment on or make changes to this bug.