Closed Bug 680060 Opened 13 years ago Closed 13 years ago

[queryCommandEnabled] check `GetIsSelectionEditable' results

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: kaze, Assigned: kaze)

References

Details

Attachments

(1 file, 2 obsolete files)

patch proposal
7.26 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
I have misused NS_SUCCEEDED in bug 676401. This should be fixed ASAP.
Depends on: 676401
Attached patch patch proposal (obsolete) — — Splinter Review 
I’m sorry, I had completely misunderstood what NS_SUCCEEDED was about. This patch should fix it, thanks Ms2ger for pointing out.

The test included in bug 676401 still applies (and passes).
Assignee: nobody → kaze
Status: NEW → ASSIGNED
Attachment #554042 - Flags: review?(ehsan)
Attached patch patch proposal (obsolete) — — Splinter Review 
One minute agot on #developers:

   <Ms2ger> kaze, looks good, but I'd prefer if you used "rv"
            instead of "res", like everyone outside editor/ does :)   

So be it! :-)
Attachment #554042 - Attachment is obsolete: true
Attachment #554042 - Flags: review?(ehsan)
Attached patch patch proposal — — Splinter Review 
sorry, forgot an `hg qrefresh' before uploading :-s
Attachment #554051 - Attachment is obsolete: true
Attachment #554053 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/fae3f1a9327b
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: