Closed
Bug 680060
Opened 14 years ago
Closed 14 years ago
[queryCommandEnabled] check `GetIsSelectionEditable' results
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: kaze, Assigned: kaze)
References
Details
Attachments
(1 file, 2 obsolete files)
|
7.26 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
I have misused NS_SUCCEEDED in bug 676401. This should be fixed ASAP.
|
Assignee | |
Comment 1•14 years ago
|
||
I’m sorry, I had completely misunderstood what NS_SUCCEEDED was about. This patch should fix it, thanks Ms2ger for pointing out.
The test included in bug 676401 still applies (and passes).
|
|
Assignee | |
Comment 2•14 years ago
|
||
One minute agot on #developers:
<Ms2ger> kaze, looks good, but I'd prefer if you used "rv"
instead of "res", like everyone outside editor/ does :)
So be it! :-)
Attachment #554042 -
Attachment is obsolete: true
Attachment #554042 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 3•14 years ago
|
||
sorry, forgot an `hg qrefresh' before uploading :-s
Attachment #554051 -
Attachment is obsolete: true
|
||
Updated•14 years ago
|
Attachment #554053 -
Flags: review+
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•