The default bug view has changed. See this FAQ.

[queryCommandEnabled] check `GetIsSelectionEditable' results

RESOLVED FIXED in mozilla9

Status

()

Core
Editor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: kaze, Assigned: kaze)

Tracking

Trunk
mozilla9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
I have misused NS_SUCCEEDED in bug 676401. This should be fixed ASAP.
(Assignee)

Updated

6 years ago
Depends on: 676401
(Assignee)

Comment 1

6 years ago
Created attachment 554042 [details] [diff] [review]
patch proposal

I’m sorry, I had completely misunderstood what NS_SUCCEEDED was about. This patch should fix it, thanks Ms2ger for pointing out.

The test included in bug 676401 still applies (and passes).
Assignee: nobody → kaze
Status: NEW → ASSIGNED
Attachment #554042 - Flags: review?(ehsan)
(Assignee)

Comment 2

6 years ago
Created attachment 554051 [details] [diff] [review]
patch proposal

One minute agot on #developers:

   <Ms2ger> kaze, looks good, but I'd prefer if you used "rv"
            instead of "res", like everyone outside editor/ does :)   

So be it! :-)
Attachment #554042 - Attachment is obsolete: true
Attachment #554042 - Flags: review?(ehsan)
(Assignee)

Comment 3

6 years ago
Created attachment 554053 [details] [diff] [review]
patch proposal

sorry, forgot an `hg qrefresh' before uploading :-s
Attachment #554051 - Attachment is obsolete: true

Updated

6 years ago
Attachment #554053 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/fae3f1a9327b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.