Closed
Bug 680182
Opened 13 years ago
Closed 13 years ago
GC dumping needs to handle JSScript gcthings
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 674251
People
(Reporter: sfink, Unassigned)
References
Details
Attachments
(1 file)
|
1.44 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
Once scripts are gcthings, we need to be able to dump them. (Without this, there's an assertion failure.)
Attachment #554158 -
Flags: review?(continuation)
|
||
Comment 1•13 years ago
|
||
Does this patch do something sensible if filename is null? Maybe you should just use 'script' in that case?
|
Reporter | |
Comment 2•13 years ago
|
||
It will end up printing "(null):0". It uses JS_snprintf, and I just confirmed that it explicitly handles NULL values.
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 554158 [details] [diff] [review]
Handle JSTRACE_SCRIPT
Review of attachment 554158 [details] [diff] [review]:
-----------------------------------------------------------------
Well, looks good to me then, though I'm not a JS peer. And as I said, it probably make sense to just fold this into Igor's patch.
Attachment #554158 -
Flags: review?(continuation) → review+
|
|
||
Comment 4•13 years ago
|
||
Folded into Igor's patch.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•