Closed Bug 680201 Opened 8 years ago Closed 6 years ago

test_webcal.js fails due to redefinition of Cc

Categories

(Calendar :: Build Config, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: standard8, Assigned: Fallen)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Having just enabled unit tests on Calendar, on the Linux 64 box we're seeing:

TEST-UNEXPECTED-FAIL | /buildbot/comm-central-lightning-linux64/build/objdir-tb/mozilla/_tests/xpcshell/calendar/test/unit/test_webcal.js | test failed (with xpcshell return code: 3), see following log:
>>>>>>>
/buildbot/comm-central-lightning-linux64/build/objdir-tb/mozilla/dist/bin/components/httpd.js:51: TypeError: redeclaration of const Cc
<<<<<<<

I'm therefore disabling the test for now so that the builds will be green still.
Checked in the patch to disable the test: http://hg.mozilla.org/comm-central/rev/1f48f873106e
Depends on: 405007
Attached patch Fix - v1 β€” β€” Splinter Review
httpd.js has evolved quite a bit, its time to freshen up this test. Unfortunately we cannot test webcals:// yet due to bug 466524.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8383778 - Flags: review?(mohit.kanwal)
Priority: -- → P1
Comment on attachment 8383778 [details] [diff] [review]
Fix - v1

Review of attachment 8383778 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Tested all the unit tests including this one. Passes. I must say running all the tests takes longer than building the source :) Also the patch does not have a commit message. Setting +  for review.
Attachment #8383778 - Flags: review?(mohit.kanwal) → review+
Pushed to comm-central changeset e29d9bda46d3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.2
You need to log in before you can comment on or make changes to this bug.