Closed Bug 680275 Opened 8 years ago Closed 8 years ago

test_delay_load.html incorrectly appends a video to a new window before it has begun loading

Categories

(Core :: Audio/Video, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: jdm, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [inbound])

Attachments

(2 files, 1 obsolete file)

This only passes in Firefox because we happen to return to the event loop and run the event that starts the load while opening the new window. In Fennec, this doesn't occur, and we don't start the load until after the video has been appended to the new window. This causes the load to fail, because it's a relative URL from about:blank.
Attachment #554230 - Attachment is obsolete: true
Attachment #554230 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/cd982d1f49d6
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
The landing of this seems to have caused an issue when I run the content/media mochitests. The test_delay_load.html test now leaves a popup window open at the end of the tests. Reverting the patch in this bug fixes it for me.
The problem seems to be that onloadstart is never called for the element that gets put in the other window. At least the event handler never fires.
OK, so what happens is that v.onloadstart does window.open, which seems to spin the event loop so that the load event fires in there. Which means loaded() actually runs before we add the window to 'testWindows', so the window isn't closed.

For the test to work we really need to avoid our events firing during window.open. I'll try doing the window.open early, outside the event handler.
Attachment #576056 - Flags: review?(chris.double) → review+
https://hg.mozilla.org/mozilla-central/rev/10f58db28c81
Target Milestone: mozilla9 → mozilla11
You need to log in before you can comment on or make changes to this bug.