The default bug view has changed. See this FAQ.

onEnterFrame does not work with tracejit

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla9
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Debug mode needs to inhibit the tracejit.

var g = newGlobal('new-compartment');
g.eval("function f() { return 1; }\n");
var N = g.N = RUNLOOP + 2;
g.eval("function h() {\n" +
       "    for (var i = 0; i < N; i += f()) {}\n" +
       "}");
g.h(); // record loop

var dbg = Debugger(g);
var log = '';
dbg.onEnterFrame = function (frame) { log += frame.callee.name; };
g.h();
assertEq(log, 'h' + Array(N + 1).join('f'));
(Assignee)

Comment 1

6 years ago
Created attachment 554465 [details] [diff] [review]
v1

For some reason we had tests onEnterFrame-{01,02,03,05}.js but not 04. I renamed 05 to 04. That's why the patch looks I'm mangling 05. Actually it's a whole new test.
Assignee: general → jorendorff
Attachment #554465 - Flags: review?(dvander)
(Assignee)

Comment 2

6 years ago
Comment on attachment 554465 [details] [diff] [review]
v1

Withdrawing. New patch in a sec.
Attachment #554465 - Flags: review?(dvander)
(Assignee)

Comment 3

6 years ago
Created attachment 554498 [details] [diff] [review]
v2

The actual operational difference between v1 and v2 is that v2 has this:

>     for (ThreadContextRange r(cx); !r.empty(); r.popFront()) {
>         JSContext *cx = r.front();
>+        if (cx->compartment == this) 
>             cx->updateJITEnabled();
>     }

But I also factored out ThreadContextRange since the #ifdefs made a big mess of that code.
Attachment #554465 - Attachment is obsolete: true
Attachment #554498 - Flags: review?(dvander)
Attachment #554498 - Flags: review?(dvander) → review+
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/305a3a0e26fd
Whiteboard: [inbound]
(Assignee)

Comment 5

6 years ago
Probably fine, but backed out due to problems with patches for bug 673125.
Whiteboard: [inbound]
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/dad9e816d52d
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/dad9e816d52d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
(Assignee)

Updated

6 years ago
Duplicate of this bug: 677373
You need to log in before you can comment on or make changes to this bug.