680428 - onEnterFrame does not work with tracejit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Debug mode needs to inhibit the tracejit.

var g = newGlobal('new-compartment');
g.eval("function f() { return 1; }\n");
var N = g.N = RUNLOOP + 2;
g.eval("function h() {\n" +
       "    for (var i = 0; i < N; i += f()) {}\n" +
       "}");
g.h(); // record loop

var dbg = Debugger(g);
var log = '';
dbg.onEnterFrame = function (frame) { log += frame.callee.name; };
g.h();
assertEq(log, 'h' + Array(N + 1).join('f'));

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

For some reason we had tests onEnterFrame-{01,02,03,05}.js but not 04. I renamed 05 to 04. That's why the patch looks I'm mangling 05. Actually it's a whole new test.

Comment 2

[Jason Orendorff [:jorendorff]]

Comment on attachment 554465 [details] [diff] [review]
v1

Withdrawing. New patch in a sec.

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: v2

The actual operational difference between v1 and v2 is that v2 has this:

>     for (ThreadContextRange r(cx); !r.empty(); r.popFront()) {
>         JSContext *cx = r.front();
>+        if (cx->compartment == this) 
>             cx->updateJITEnabled();
>     }

But I also factored out ThreadContextRange since the #ifdefs made a big mess of that code.

Comment 4

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/305a3a0e26fd

Comment 5

[Jason Orendorff [:jorendorff]]

Probably fine, but backed out due to problems with patches for bug 673125.

Comment 6

[Jason Orendorff [:jorendorff]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/dad9e816d52d

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/dad9e816d52d