Closed Bug 680528 Opened 9 years ago Closed 9 years ago
Make use of the cached value for user agent in Plugin
Flash makes this call fairly often during startup. Since we currently cache this in a member variable we might as well make use of it. Granted the value could change while the browser is running, but I don't think we should worry about that with plugins instances.
Assignee: nobody → jmathies
Attachment #554509 - Flags: review?(bent.mozilla)
Comment on attachment 554509 [details] [diff] [review] patch I'd prefer to set mUserAgent as a void string in the constructor, then only call if the string remains void (I think you can override the useragent string with anything, even the empty string).
Attachment #554509 - Flags: review?(bent.mozilla) → review-
Comment on attachment 554517 [details] [diff] [review] patch Thanks, looks good!
Attachment #554517 - Flags: review?(bent.mozilla) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.