The default bug view has changed. See this FAQ.

Make use of the cached value for user agent in PluginModuleChild

RESOLVED FIXED in mozilla9

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
mozilla9
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.23 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Flash makes this call fairly often during startup. Since we currently cache this in a member variable we might as well make use of it. Granted the value could change while the browser is running, but I don't think we should worry about that with plugins instances.
(Assignee)

Comment 1

6 years ago
Created attachment 554509 [details] [diff] [review]
patch
Assignee: nobody → jmathies
Attachment #554509 - Flags: review?(bent.mozilla)
Comment on attachment 554509 [details] [diff] [review]
patch

I'd prefer to set mUserAgent as a void string in the constructor, then only call if the string remains void (I think you can override the useragent string with anything, even the empty string).
Attachment #554509 - Flags: review?(bent.mozilla) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 554517 [details] [diff] [review]
patch

nice catch.
Attachment #554509 - Attachment is obsolete: true
Attachment #554517 - Flags: review?(bent.mozilla)
Comment on attachment 554517 [details] [diff] [review]
patch

Thanks, looks good!
Attachment #554517 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 5

6 years ago
on inbound:
http://hg.mozilla.org/integration/mozilla-inbound/rev/008e94e45b29
http://hg.mozilla.org/mozilla-central/rev/008e94e45b29
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.