Closed
Bug 680528
Opened 13 years ago
Closed 13 years ago
Make use of the cached value for user agent in PluginModuleChild
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla9
People
(Reporter: jimm, Assigned: jimm)
Details
Attachments
(1 file, 1 obsolete file)
|
1.23 KB,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
Flash makes this call fairly often during startup. Since we currently cache this in a member variable we might as well make use of it. Granted the value could change while the browser is running, but I don't think we should worry about that with plugins instances.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → jmathies
Attachment #554509 -
Flags: review?(bent.mozilla)
Comment on attachment 554509 [details] [diff] [review]
patch
I'd prefer to set mUserAgent as a void string in the constructor, then only call if the string remains void (I think you can override the useragent string with anything, even the empty string).
Attachment #554509 -
Flags: review?(bent.mozilla) → review-
|
|
Assignee | |
Comment 3•13 years ago
|
||
nice catch.
Attachment #554509 -
Attachment is obsolete: true
Attachment #554517 -
Flags: review?(bent.mozilla)
Comment on attachment 554517 [details] [diff] [review]
patch
Thanks, looks good!
Attachment #554517 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
||
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•