Closed Bug 680534 Opened 10 years ago Closed 10 years ago

Clean up IDL Directory Rules in rules.mk

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla9

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Currently, the $(IDL_DIR) target in rules.mk has the following issues:

1) It is defined as a double colon rule, so it gets executed every single time
2) It is defined twice

The attached patch converts it to a regular rule and removes an inner definition. I believe the remaining definition is always in an outer scope and is thus always defined to the bits that need it. Although, the conditional statements in this part of rules.mk are nested pretty deep, so I could be wrong.

I also believe everything writing into $(IDL_DIR) has $(IDL_DIR) as a prerequisite, so removing the double colon should be safe.

I've done the following to verify the change:

* Built w/ make from empty objdir
* Rebuilt a subcomponent w/ make that used to always nsinstall $(IDL_DIR) and verified it didn't do this any more

I'm not sure how much this improves build times by, but it should be greater than 0.
Attachment #554512 - Flags: review?(khuey)
Added missing identical change to JS's rules.mk and added bug number to summary.
Assignee: nobody → gps
Attachment #554512 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #554512 - Flags: review?(khuey)
Attachment #554520 - Flags: review?(khuey)
Blocks: 680369
OS: Windows 2000 → All
Version: unspecified → Trunk
Comment on attachment 554520 [details] [diff] [review]
Remove double colon and redundancy of $(IDL_DIR), v2

Can we drop the comment above the $(IDL_DIR) rule we're keeping.  I don't think that's been accurate in the better part of a decade ...
Attachment #554520 - Flags: review?(khuey) → review+
This is the same patch that was r+ by khuey except the outdated comment has been removed, per comment from khuey.
Attachment #554520 - Attachment is obsolete: true
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/1ee70d6bb2c8
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla9
http://hg.mozilla.org/mozilla-central/rev/1ee70d6bb2c8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.