680576 - tab.url is incorrect for unrestored and restoring tabs

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Dietrich Ayala (:dietrich)]

the tabs code currently uses browser.contentDocument.location, which is not correct for tabs that are not yet restored.

tabs can be restored either on-demand or be in the queue for being restored, but for all intent and appearance be loaded (eg, title and favicon) even if never activated during a session.

zpao said browser.currentURI should be correct.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/229

Pointer to Github pull-request

Comment 2

[Dietrich Ayala (:dietrich)]

Comment on attachment 554590 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/229

fixed session restore incompatibility as well as made both properties e10s-ready (in terms of out-of-process content, not out-of-process jetpack).

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 554590 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/229

Thanks, Dietrich!

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

https://github.com/mozilla/addon-sdk/commit/125a3d0df3999ab5a6260653d82f06b4341c2e05

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Dietrich: is this a problem on Firefox 7 as well or only newer versions of Firefox (i.e. should I land this fix on the stabilization branch for SDK 1.1, which targets Firefox 7)?

Comment 6

[Dietrich Ayala (:dietrich)]

Yes, could be a problem for any release >=4, since that's when cascading session restore first landed.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Cherry pick commit:

https://github.com/mozilla/addon-sdk/commit/63d60103653f6eaf9d82147f75b26ded2ccddacb