680657 - Give thinner splitters like Thunderbird

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Richard Marti (:Paenglab)]

Thunderbird has now splitters with a visible width of 1px. Lightning should follow to look consistent.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: the patch

This patch gives the 1px thin look of Thunderbird. I had also to rmove some borders of other boxes for the 1px appearance. The splitters have still a grab width of 5px but are looking 1px wide.

I don't ask for ui-r because Andreas gave the okay for the splitters in Thunderbird.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: patch v2

I have overseen the splitter in the today pane.

Comment 3

[Decathlon]

Comment on attachment 554713 [details] [diff] [review]
patch v2

I apologize Philipp, I've just realized this is a Linux specific bug. I don't have a machine with Linux installed, so I can't test the patch.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Ok, I'll take care when I'm back to my linux box.

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 554713 [details] [diff] [review]
patch v2

In general the code looks good, but if you have a few events in your unifinder and the left pane open, then the information looks pretty packed.

I'm not really sure what to do to alleviate this though, so r=philipp as is. If you have any suggestions I'm open to them!

Comment 6

[Richard Marti (:Paenglab)]

Then this is the same case with Vista/Win7 where the thin splitters are already implemented.

I'm thinking about removing the list borders in the today pane on Vista/Win7 and Linux. This makes the pane lighter because it has now a lot of lines (borders) in this pane. Maybe you can check my theme "Nuvola TB" how it could look without this borders.

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Ya think you could attach me a screenshot, for the lazy? ;-)

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Screenshot of calendar with tasks and without borders in in the today pane

I wasn't so lazy ;) and removed the borders of the lists in the today pane for the screenshot.

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 560728 [details]
Screenshot of calendar with tasks and without borders in in the today pane

Ah, ok I see what you mean. Maybe you can make the horizontal line between the events and tasks pane a double-line? This way its more obvious that these are two separate entities.

Also I think there is an issue with the bottom border of the today pane?

Comment 10

[Richard Marti (:Paenglab)]

(In reply to Philipp Kewisch [:Fallen] from comment #9)
> Comment on attachment 560728 [details]
> Screenshot of calendar with tasks and without borders in in the today pane
> 
> Ah, ok I see what you mean. Maybe you can make the horizontal line between
> the events and tasks pane a double-line? This way its more obvious that
> these are two separate entities.

You mean a 2px splitter instead of 1px? If it's okay I'll do this with this patch on check-in.

Should I apply this patch also to comm-aurora? The thinner splitters are also in comm-aurora TB.

> Also I think there is an issue with the bottom border of the today pane?

When you look at the mail part then you see a border on top of the status bar. Then only the today pane is correct and the other elements have an issue ;)

The screenshot was not made with a patch, it was only manipulated with DOMi and I missed to remove the bottom border.

Comment 11

[Philipp Kewisch [:Fallen][📱📆]]

(In reply to Richard Marti [:paenglab] from comment #10)

> You mean a 2px splitter instead of 1px? If it's okay I'll do this with this
> patch on check-in.
I was rather thinking two lines, i.e black-transparent-black, i.e =======.

Doing this on check-in is fine.

> 
> Should I apply this patch also to comm-aurora? The thinner splitters are
> also in comm-aurora TB.

Yes please

> When you look at the mail part then you see a border on top of the status
> bar. Then only the today pane is correct and the other elements have an
> issue ;)
Ok, agreed. Just fix it however Thunderbird is doing :)

Comment 12

[Richard Marti (:Paenglab)]

Attachment: Double border

(In reply to Philipp Kewisch [:Fallen] from comment #11)
> 
> I was rather thinking two lines, i.e black-transparent-black, i.e =======.

Like this screenshot?

> Doing this on check-in is fine.

I'm not doing this in this patch but in the future border patch.

Comment 13

[Philipp Kewisch [:Fallen][📱📆]]

> Like this screenshot?
Yes, thats what I was looking for!

Comment 14

[Richard Marti (:Paenglab)]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/5a55f6aeb468>

Comment 15

[Richard Marti (:Paenglab)]

Backported to comm-aurora <http://hg.mozilla.org/releases/comm-aurora/rev/8efe8b2979c1>