The default bug view has changed. See this FAQ.

GPOS contextual chaining positioning does not work

VERIFIED FIXED in Firefox 9

Status

()

Core
Graphics
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: Khaled Hosny, Assigned: Khaled Hosny)

Tracking

Trunk
mozilla10
x86
All
Points:
---

Firefox Tracking Flags

(firefox7 affected, firefox8 affected, firefox9- fixed)

Details

(Whiteboard: [qa!])

Attachments

(4 attachments)

(Assignee)

Description

6 years ago
Created attachment 554656 [details] [diff] [review]
Backported upstream patch

Due to a bug in HarfBuzz, contextual chaining positioning are broken and do not get applied it all. It have been fixed in HarfBuzz master (http://cgit.freedesktop.org/harfbuzz/commit/?id=cc1a8a938b4c13e76b58825a9e1951c4134e634a). The attached patch is the original upstream commit applied to mozilla-centeral, I built and tested it and it seem to work as expected.
(Assignee)

Comment 1

6 years ago
Created attachment 554658 [details]
Test file

This is a test file showing the issue with embedded woff font (the font is OFL licensed, base64 encoded just for convenience).
(Assignee)

Updated

6 years ago
Attachment #554658 - Attachment mime type: text/plain → text/html
(Assignee)

Comment 2

6 years ago
Created attachment 554659 [details]
Current rendering (FireFox 6)
(Assignee)

Comment 3

6 years ago
Created attachment 554660 [details]
After applying the patch (mozilla-centeral)
I'd really prefer to take a full harfbuzz update soon, but if we don't get that done in good time before the next Aurora train leaves, we should consider cherry-picking this fix.
Status: UNCONFIRMED → NEW
Component: Layout: Text → Graphics
Ever confirmed: true
QA Contact: layout.fonts-and-text → thebes
Depends on: 695857
Comment on attachment 554656 [details] [diff] [review]
Backported upstream patch

As bug 695857 (harfbuzz update) is still awaiting review, I think we should take this fix now as a stop-gap. Hence r=me.
Attachment #554656 - Flags: review+
Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0355183e7170
Target Milestone: --- → mozilla10
Do we need this in Firefox 9?
https://hg.mozilla.org/mozilla-central/rev/0355183e7170
Assignee: nobody → khaledhosny
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #7)
> Do we need this in Firefox 9?

Well... we've been shipping the buggy behavior for several versions now, but it would be nice to fix it sooner rather than later. In particular, I believe (based on email correspondence with the font developer concerned) that this affects a new Arabic webfont that the BBC Arabic site is about to deploy. So until we fix it, that's a pretty major site that will look bad in Firefox. There are presumably other affected fonts/sites as well, though I don't know how widespread the issue is.
Comment on attachment 554656 [details] [diff] [review]
Backported upstream patch

Review of attachment 554656 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should do this.

This is a fairly simple patch that will fix rendering on a major site.
Attachment #554656 - Flags: approval-mozilla-beta?
Attachment #554656 - Flags: approval-mozilla-aurora?
status-firefox7: --- → affected
status-firefox8: --- → affected
status-firefox9: --- → affected
tracking-firefox9: --- → ?
Comment on attachment 554656 [details] [diff] [review]
Backported upstream patch

[Triage Comment]
* Approving for aurora given the affect to BBC's rollout
* Denying for beta since this wouldn't cause a re-roll

Please make sure to land this today to make the cutover.
Attachment #554656 - Flags: approval-mozilla-beta?
Attachment #554656 - Flags: approval-mozilla-beta-
Attachment #554656 - Flags: approval-mozilla-aurora?
Attachment #554656 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/d518534ad916
status-firefox9: affected → fixed
Whiteboard: [qa+]
The test file https://bug680692.bugzilla.mozilla.org/attachment.cgi?id=554658 is displayed like in the attachment https://bug680692.bugzilla.mozilla.org/attachment.cgi?id=554660 on:

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0a1) Gecko/20111121 Firefox/11.0a1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0a2) Gecko/20111121 Firefox/10.0a2

Mozilla/5.0 (Windows NT 6.1; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 6.1; rv:11.0a1) Gecko/20111121 Firefox/11.0a1
Mozilla/5.0 (Windows NT 6.1; rv:10.0a2) Gecko/20111121 Firefox/10.0a2

Mozilla/5.0 (Windows NT 5.1; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Windows NT 5.1; rv:11.0a1) Gecko/20111121 Firefox/11.0a1
Mozilla/5.0 (Windows NT 5.1; rv:10.0a2) Gecko/20111121 Firefox/10.0a2

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0a1) Gecko/20111121 Firefox/11.0a1

Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20100101 Firefox/9.0
Mozilla/5.0 (X11; Linux x86_64; rv:10.0a2) Gecko/20111121 Firefox/10.0a2
Mozilla/5.0 (X11; Linux x86_64; rv:11.0a1) Gecko/20111122 Firefox/11.0a1

Is that correct ? Can I change the resolution to verified fixed ?
I believe that is correct. Khaled, please reopen this bug if it is not working the way you intended.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]

Updated

5 years ago
tracking-firefox9: ? → -
You need to log in before you can comment on or make changes to this bug.