xpcshell.ini missing in calendar/test

RESOLVED FIXED in 1.1

Status

Calendar
Sunbird Only
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: ewong, Assigned: ewong)

Tracking

unspecified
x86
All
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
+++ This bug was initially created as a clone of Bug #678430 +++

xpcshell.ini is missing from calendar/test.
(Assignee)

Comment 1

7 years ago
Created attachment 554702 [details] [diff] [review]
Added xpcshell.ini to calendar/test
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #554702 - Flags: review?(philipp)
(Assignee)

Comment 2

7 years ago
Created attachment 554711 [details] [diff] [review]
Added xpcshell.ini to calendar/test (v2)
Attachment #554702 - Attachment is obsolete: true
Attachment #554702 - Flags: review?(philipp)
Attachment #554711 - Flags: review?(philipp)
(Assignee)

Updated

7 years ago
Blocks: 680753
Comment on attachment 554711 [details] [diff] [review]
Added xpcshell.ini to calendar/test (v2)

So this is needed even though we have test/unit/xpcshell.ini now? I'd somehow prefer if we only needed one file, but given our unit test file is included from mail-land, it would probably cause xpcshell-core.ini to be included twice.

Given I see no easy way around this and its sunbird only anyway, r=philipp
Attachment #554711 - Flags: review?(philipp) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Pushed to https://hg.mozilla.org/comm-central/rev/fb4830d1cce8
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Trunk
You need to log in before you can comment on or make changes to this bug.