680779 - <input type=file multiple> should ensure that at least one file can be chosen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Josh Matthews [:jdm]]

According to bug 671833 and its duplicates, a file input with the multiple attribute will not bring up an input dialog at all. This is a very bad UX interaction; we should ensure that if we don't have the ability to choose multiple files we still act like a non-multiple file input.

Comment 1

[Alexandre Alapetite]

Indeed, other Web browsers on Android currently seem to ignore the @multiple element, falling back to the same behaviour as what they do for single files:

- Android browser (checked on 2.3.3, Samsung Galaxy S 2) is able to select a single file via an external program (e.g. Picture Gallery, Music, third-party file manager)
- Opera Mobile 11.10 has it own file-picker, but still limited to picking a single file.

- Demo: http://demos.hacks.mozilla.org/openweb/multipleFiles/
- Simpler demo: http://alexandre.alapetite.fr/divers/vrac/20110821-input-file-multiple.html

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/452d6e414032

Comment 4

[Mounir Lamouri (:mounir)]

http://hg.mozilla.org/mozilla-central/rev/452d6e414032

Comment 5

[Andreea Pod]

Hey guys, is there a way for me to verify this?

Comment 6

[Matt Brubeck (:mbrubeck)]

(In reply to Andreea Pod from comment #5)
> Hey guys, is there a way for me to verify this?

Tapping on the "Browse" button under "Multiple files" on http://alexandre.alapetite.fr/divers/vrac/20110821-input-file-multiple.html should prompt you to select an app (e.g. Gallery) to choose a file.

Comment 7

[Andreea Pod]

Verified fixed on: Mozilla /5.0 (Android;Linux armv7l;rv:9.0a1) Gecko/20110830 Firefox/9.0a1 Fennec/9.0a1 
Device: LG Optimus 2X (Android 2.2)

Comment 8

[Alexandre Alapetite]

Verified fixed on: "Mozilla /5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110830 Firefox/9.0a1 Fennec/9.0a1" from http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/latest-jaegermonkey-android/fennec-9.0a1.en-US.android-arm.apk
Device: Samsung Galaxy S2 (Android 2.3.3)