680837 - Instrument Firebug test-bot to run with SeaMonkey

Status: RESOLVED INVALID

(Testing :: General, defect)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This report is related to a Firebug issue reported here:
http://code.google.com/p/fbug/issues/detail?id=4430

Firebug 1.8 is currently compatible with SeaMonkey and it would safe our time if it's also automatically tested by Firebug TestBot.

The test bot can be currently instrumented to run Firebug automated tests regularly with various Firefox releases/channels.

However it isn't possible to instrument the bot to test Firebug + SeaMonkey combo. Could we add such support?

Honza

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Likewise, FB 1.9 works with (at least) SM 2.5 - 2.9a1.

Is there anything the SeaMonkey team (esp. me) can do to get this going? E.g. a pointer to the test bot source?

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #1)
> Likewise, FB 1.9 works with (at least) SM 2.5 - 2.9a1.
> 
> Is there anything the SeaMonkey team (esp. me) can do to get this going?
> E.g. a pointer to the test bot source?
That would be great!

Clint, do you have more info about where the test-bot source is located?

Honza

Comment 3

[cmtalbert]

(In reply to Jan Honza Odvarko from comment #2)
> (In reply to Jens Hatlak (:InvisibleSmiley) from comment #1)
> > Likewise, FB 1.9 works with (at least) SM 2.5 - 2.9a1.
> > 
> > Is there anything the SeaMonkey team (esp. me) can do to get this going?
> > E.g. a pointer to the test bot source?
> That would be great!
> 
> Clint, do you have more info about where the test-bot source is located?
Oh wow, how'd I miss this bug.  Yeah, the source is here: https://github.com/mozilla/Firebug-Test-Runner

Let me know if you have any questions.  It should be pretty straightforward to make it work with seamonkey.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Clint Talbert ( :ctalbert ) from comment #3)
> the source is here:
> https://github.com/mozilla/Firebug-Test-Runner

Thanks! I had to additionally install python-setuptools and python-virtualenv (and learn how to use them correctly), but with that I got it working.

> Let me know if you have any questions.  It should be pretty straightforward
> to make it work with seamonkey.

Unfortunately I'm not a Python developer so I cannot make the changes myself. But I can tell you what I did to make it work, and what I would do if I were you:

* runFBTests/execute_fb_tests.py:
** replace all occurrences of "firefox" by "seamonkey"
** replace all occurrences of "mozilla-central" by "comm-central"
** replace all occurrences of "mozilla-" by "comm-"

I'd introduce a new parameter that allows to specify the product to test, defaulting to "firefox". If "seamonkey" would be specified, the internal repository prefix would be changed from "mozilla-" to "comm-". Additionally, a "build" value of "central" would need to be changed to "central-trunk" so getlatesttinderbox is called with a "product" parameter that fits this setup:
http://stage.mozilla.org/pub/mozilla.org/seamonkey/tinderbox-builds/

* getlatesttinderbox/get_latest.py:
** replace all occurrences of "firefox" by "seamonkey"
** replace all occurrences of "mozilla-central" by "comm-central-trunk"

getlatesttinderbox supports a "product" parameter, so "mozilla-central" can be replaced by "comm-central-trunk" if the caller is adapted. However, "firefox" is hard-coded in BASE_URL. One way to solve this problem would be to introduce a check like this: If product begins with "comm-", use "seamonkey" instead of "firefox" in BASE_URL (else use "firefox"). That's not very future-proof, though (think Thunderbird, Lightning) so maybe an additional parameter defaulting to "firefox" would be better.


With the above I got the whole test suite running with SeaMonkey. :-) I didn't test whether all tests succeeded, but there was definitely some activity and no hang.

I hope one of you guys can do the actualy Python programming as outlined above. If you need further information, let me know.

Comment 5

[Phoenix]

Progress stalled?

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Note that Firebug team is still very interested to have this support.
Honza

Comment 7

[cmtalbert]

God yes, I'm sorry. It's totally stalled. I've got no time and no one to help on this at the moment. If I can find a contributor with a few cycles I'll see if I can get it to them.

Comment 8

[Rahul Nair]

is this a [good first bug]. I am willing to take it up if someone can mentor. Disclaimer: Newbie, self taught Python enthusiast from India. If accepted, it's be my very first contribution anywhere.

Comment 9

[Andrew Halberstadt [:ahal]]

My inclination is that this wouldn't be the best first bug as the requirements aren't very well defined (maybe see this list too: http://www.joshmatthews.net/bugsahoy/?py=1). You may need to do a fair bit of debugging and mucking around to get things working.

That being said if you want to tackle it, I'm happy to help you along the way. But first lets make sure this is still something that's needed.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

:ahal, is this bug still valid as much time has passed?  If so, maybe a bit more context here so folks interested in jumping in on this for a good next bug could do so without a lot of headache.

Comment 11

[Andrew Halberstadt [:ahal]]

Oh man, I haven't looked at the Firebug Test Bot in years. I don't think it's even running against Firefox anymore. To any future person trying to get Firebug tests running in CI, I'd strongly recommend looking into using something like TravisCI or similar tools.

I think this should be marked INVALID, though I'll leave that up to :Honza.

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yep, this is invalid, Firebug is now integrated with Travis.
Honza