Closed
Bug 680855
Opened 13 years ago
Closed 13 years ago
Cleanup nsVCardAddress.h
Categories
(MailNews Core :: Import, defect)
MailNews Core
Import
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 9.0
People
(Reporter: hiro, Assigned: hiro)
Details
Attachments
(2 files)
|
1.64 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
|
845 bytes,
patch
|
standard8
:
review-
|
Details | Diff | Splinter Review |
nsVCardAddress.h should be cleaned up.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #554808 -
Flags: review?(mbanner)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #554807 -
Flags: review?(mbanner)
|
||
Updated•13 years ago
|
Attachment #554807 -
Flags: review?(mbanner) → review+
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → hiikezoe
Keywords: checkin-needed
|
||
Comment 2•13 years ago
|
||
http://hg.mozilla.org/comm-central/rev/dd57372e4aa0 first patch checked-in
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 554808 [details] [diff] [review]
The destrutor should not be virtual
Thanks for the suggestion. I've had a chat around and we've agreed that this doesn't really gain us anything in performance, and actually makes it harder if we (or an extension) did decide to sub-class this class. Hence we'd prefer these to be left in.
Thanks for the idea anyway.
Attachment #554808 -
Flags: review?(mbanner) → review-
|
|
||
Comment 4•13 years ago
|
||
Marking this fixed now, assuming we're complete here.
Thanks for the patches.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•