Closed Bug 680855 Opened 9 years ago Closed 9 years ago

Cleanup nsVCardAddress.h

Categories

(MailNews Core :: Import, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 9.0

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(2 files)

nsVCardAddress.h should be cleaned up.
Attachment #554808 - Flags: review?(mbanner)
Attachment #554807 - Flags: review?(mbanner)
Attachment #554807 - Flags: review?(mbanner) → review+
Assignee: nobody → hiikezoe
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/dd57372e4aa0 first patch checked-in
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 9.0
Comment on attachment 554808 [details] [diff] [review]
The destrutor should not be virtual

Thanks for the suggestion. I've had a chat around and we've agreed that this doesn't really gain us anything in performance, and actually makes it harder if we (or an extension) did decide to sub-class this class. Hence we'd prefer these to be left in.

Thanks for the idea anyway.
Attachment #554808 - Flags: review?(mbanner) → review-
Marking this fixed now, assuming we're complete here.

Thanks for the patches.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.