Closed
Bug 680872
Opened 14 years ago
Closed 14 years ago
PolyIC.cpp fails to compile on mingw-w64
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: jacek, Assigned: jacek)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
1.34 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
That's because of Atom* to unsigned long cast that is losing precision on win64 and is an error by default on GCC. I've fixed is by using "%p" in the format and passing a pointer to JaegerSpew, so that no pointer to int conversion is needed.
Attachment #554827 -
Flags: review?(jorendorff)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 554827 [details] [diff] [review]
fix v1.0
"I love you, GCC, but sometimes it seems like whatever I do, it's not good enough for you"
Attachment #554827 -
Flags: review?(jorendorff) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
(In reply to Jason Orendorff [:jorendorff] from comment #1)
> Comment on attachment 554827 [details] [diff] [review]
> fix v1.0
>
> "I love you, GCC, but sometimes it seems like whatever I do, it's not good
> enough for you"
Hehe :)
http://hg.mozilla.org/integration/mozilla-inbound/rev/511103df06b4
Whiteboard: [inbound]
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in
before you can comment on or make changes to this bug.
Description
•