Closed Bug 680872 Opened 8 years ago Closed 8 years ago

PolyIC.cpp fails to compile on mingw-w64

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: jacek, Assigned: jacek)

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Attached patch fix v1.0Splinter Review
That's because of Atom* to unsigned long cast that is losing precision on win64 and is an error by default on GCC. I've fixed is by using "%p" in the format and passing a pointer to JaegerSpew, so that no pointer to int conversion is needed.
Attachment #554827 - Flags: review?(jorendorff)
Comment on attachment 554827 [details] [diff] [review]
fix v1.0

"I love you, GCC, but sometimes it seems like whatever I do, it's not good enough for you"
Attachment #554827 - Flags: review?(jorendorff) → review+
(In reply to Jason Orendorff [:jorendorff] from comment #1)
> Comment on attachment 554827 [details] [diff] [review]
> fix v1.0
> 
> "I love you, GCC, but sometimes it seems like whatever I do, it's not good
> enough for you"

Hehe :)

http://hg.mozilla.org/integration/mozilla-inbound/rev/511103df06b4
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/511103df06b4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.