680874 - ESC doesn't close the add-on selection UI

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Dão Gottwald [:dao]]

Hitting ESC should skip the dialog and start Firefox.

Comment 1

[Brian King [:kinger]]

Is it a dialog or a window? If the latter it shouldn't.

ESC is a knee-jerk reaction and this window requires more attention IMO.

Comment 2

[Dão Gottwald [:dao]]

It certainly tries to look like a dialog/wizard. And there are sensible default choices, so the user should be able to just skip the whole thing.

Comment 3

[Dave Townsend [:mossop]]

If we're showing the selection UI and it says that some add-ons will be disabled, some will have updates installed etc. Should we cancel all of those changes when the user hits esc? I ask because we cannot do the updates without keeping the UI open and it feels a little weird to disable the add-ons the user chose not to have but not to do the other actions that the user may have chose.

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to Dave Townsend (:Mossop) from comment #3)
> If we're showing the selection UI and it says that some add-ons will be
> disabled, some will have updates installed etc. Should we cancel all of
> those changes when the user hits esc? I ask because we cannot do the updates
> without keeping the UI open and it feels a little weird to disable the
> add-ons the user chose not to have but not to do the other actions that the
> user may have chose.

What about something similar to what happens on my Linux distro when abandoning a software update session? Pop up a dialog saying "This will abandon all changes you just made. [Abandon changes] [Go back to <appname>]". I know are-you-sure dialogs are much less in fashion nowadays than they used to be some years ago, but perhaps they still have some valid use cases.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Dave Townsend (:Mossop) from comment #3)
> If we're showing the selection UI and it says that some add-ons will be
> disabled, some will have updates installed etc. Should we cancel all of
> those changes when the user hits esc? I ask because we cannot do the updates
> without keeping the UI open and it feels a little weird to disable the
> add-ons the user chose not to have but not to do the other actions that the
> user may have chose.

What happens when closing the window using Alt+F4 or the upper right X?

Comment 6

[Asa Dotzler [:asa]]

release drivers would consider approving a fix but we're not going to track this through the release.

Comment 7

[Alex Limi (:limi) — Firefox UX Team]

I don't think this is worth the effort. It's a one-time dialog, and most people won't see it again. We can consider fixing it if we use this dialog again in the future.