680881 - Add a className parameter to SHELL_WRAPPER's and GETFUNC macros

Status: RESOLVED WONTFIX

(Core Graveyard :: Widget: Android, defect)

Description

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

With WebSMS (bug 674725), I'm going to introduce new Java to C++ calls and I would like them to be in GeckoSmsManager instead of GeckoAppShell (no need to make GeckoAppShell grow insanely). Likely, it might be useful for other calls.

I did extract this patch from my patch queue because any new GET_FUNC or SHELL_WRAPPER call breaks the entire patch and re-basing it is quite error-prone.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

the pattern has been to have GeckoAppShell proxy calls to other classes, so the implementation can be in GeckoSmsManager, but it would be called by way of GeckoAppShell

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to Brad Lassey [:blassey](On vacation 8/22-9/20) from comment #1)
> the pattern has been to have GeckoAppShell proxy calls to other classes, so
> the implementation can be in GeckoSmsManager, but it would be called by way
> of GeckoAppShell

With the WebAPI work, this might proxy dozen(s) of calls. Is that really what we want?

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

I'm okay with that

Comment 4

[Mounir Lamouri (:mounir)]

It's no longer in my patch queue, let's mark this WONTFIX...