Last Comment Bug 680883 - unneeded nsIPluginHost QueryInterface in sanitize.js and nsPrivateBrowsingService.js
: unneeded nsIPluginHost QueryInterface in sanitize.js and nsPrivateBrowsingSer...
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Private Browsing (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: arno renevier
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-22 06:42 PDT by arno renevier
Modified: 2011-08-23 01:29 PDT (History)
2 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch proposal (3.25 KB, patch)
2011-08-22 06:44 PDT, arno renevier
ehsan: review+
Details | Diff | Splinter Review

Description arno renevier 2011-08-22 06:42:03 PDT
Hi,
in browser/base/content/sanitize.js and browser/components/privatebrowsing/src/nsPrivateBrowsingService.js, we have
let ph = Cc["@mozilla.org/plugin/host;1"].getService(Ci.nsIPluginHost);
which is just after QueryInterfaced to nsIPluginHost again.
Comment 1 arno renevier 2011-08-22 06:44:24 PDT
Created attachment 554845 [details] [diff] [review]
patch proposal

patch proposal. I've tested it on try server:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=2a0db7f49e9e
Comment 2 Josh Matthews [:jdm] (away until 9/3) 2011-08-22 07:20:23 PDT
Comment on attachment 554845 [details] [diff] [review]
patch proposal

I think this is ehsan's code.
Comment 3 :Ehsan Akhgari 2011-08-22 11:29:25 PDT
Pushed to inbound.
Comment 4 Mounir Lamouri (:mounir) 2011-08-23 01:29:29 PDT
http://hg.mozilla.org/mozilla-central/rev/bf17068db7de

Note You need to log in before you can comment on or make changes to this bug.