Closed Bug 680883 Opened 10 years ago Closed 10 years ago

unneeded nsIPluginHost QueryInterface in sanitize.js and nsPrivateBrowsingService.js

Categories

(Firefox :: Private Browsing, defect)

Product:
Firefox
Component:
Private Browsing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: arno, Assigned: arno)

Details

Attachments

(1 file)

patch proposal
3.25 KB, patch
ehsan
: review+
Details | Diff | Splinter Review 
Hi,
in browser/base/content/sanitize.js and browser/components/privatebrowsing/src/nsPrivateBrowsingService.js, we have
let ph = Cc["@mozilla.org/plugin/host;1"].getService(Ci.nsIPluginHost);
which is just after QueryInterfaced to nsIPluginHost again.
Attached patch patch proposal — — Splinter Review 
patch proposal. I've tested it on try server:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=2a0db7f49e9e
Assignee: nobody → arno
Status: NEW → ASSIGNED
Attachment #554845 - Flags: review?(dwitte)
Comment on attachment 554845 [details] [diff] [review]
patch proposal

I think this is ehsan's code.
Attachment #554845 - Flags: review?(dwitte) → review?(ehsan)
Attachment #554845 - Flags: review?(ehsan) → review+
Pushed to inbound.
http://hg.mozilla.org/mozilla-central/rev/bf17068db7de
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.