Closed
Bug 680883
Opened 14 years ago
Closed 14 years ago
unneeded nsIPluginHost QueryInterface in sanitize.js and nsPrivateBrowsingService.js
Categories
(Firefox :: Private Browsing, defect)
Firefox
Private Browsing
Tracking
()
RESOLVED
FIXED
People
(Reporter: arno, Assigned: arno)
Details
Attachments
(1 file)
|
3.25 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
Hi,
in browser/base/content/sanitize.js and browser/components/privatebrowsing/src/nsPrivateBrowsingService.js, we have
let ph = Cc["@mozilla.org/plugin/host;1"].getService(Ci.nsIPluginHost);
which is just after QueryInterfaced to nsIPluginHost again.
|
Assignee | |
Comment 1•14 years ago
|
||
patch proposal. I've tested it on try server:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=2a0db7f49e9e
|
||
Comment 2•14 years ago
|
||
Comment on attachment 554845 [details] [diff] [review]
patch proposal
I think this is ehsan's code.
Attachment #554845 -
Flags: review?(dwitte) → review?(ehsan)
|
||
Updated•14 years ago
|
Attachment #554845 -
Flags: review?(ehsan) → review+
|
|
||
Comment 3•14 years ago
|
||
Pushed to inbound.
|
||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•