Note: There are a few cases of duplicates in user autocompletion which are being worked on.

unneeded nsIPluginHost QueryInterface in sanitize.js and nsPrivateBrowsingService.js

RESOLVED FIXED

Status

()

Product:
Firefox
Component:
Private Browsing
RESOLVED FIXED
Reported:
6 years ago
Modified:
6 years ago

People

(Reporter: arno renevier, Assigned: arno renevier)

Tracking

Version:
Trunk
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

patch proposal
3.25 KB, patch
Ehsan
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
6 years ago 
Hi,
in browser/base/content/sanitize.js and browser/components/privatebrowsing/src/nsPrivateBrowsingService.js, we have
let ph = Cc["@mozilla.org/plugin/host;1"].getService(Ci.nsIPluginHost);
which is just after QueryInterfaced to nsIPluginHost again.
(Assignee)

Comment 1

•
6 years ago 
Created attachment 554845 [details] [diff] [review]
patch proposal

patch proposal. I've tested it on try server:
http://tbpl.allizom.org/?tree=Try&usebuildbot=1&rev=2a0db7f49e9e
Assignee: nobody → arno
Status: NEW → ASSIGNED
Attachment #554845 - Flags: review?(dwitte)

Comment 2

•
6 years ago 
Comment on attachment 554845 [details] [diff] [review]
patch proposal

I think this is ehsan's code.
Attachment #554845 - Flags: review?(dwitte) → review?(ehsan)
Attachment #554845 - Flags: review?(ehsan) → review+

Comment 3

•
6 years ago 
Pushed to inbound.

Comment 4

•
6 years ago 
http://hg.mozilla.org/mozilla-central/rev/bf17068db7de
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.