680917 - Assertion failure@yarr/PageAllocation.h:103 on ia64: system page size is 0x4000 while requested size is 0x1000

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan Horak [:jhorak]]

On arch ia64 js engine is asserting at:
Assertion failure: isPageAligned(size)
(tip/js/src/yarr/PageAllocation.h:103 static WTF::PageAllocation WTF::PageAllocation::allocate(size_t, WTF::OSAllocator::Usage, bool, bool))

Called with following parameters:
WTF::PageAllocation::allocate (size=4096, usage=UnknownUsage, writable=true, executable=false)

From:
http://mxr.mozilla.org/mozilla-central/source/js/src/yarr/PageBlock.h#41
The isPageAligned check use systemPageSize() which returns 0x4000, size is 0x1000.

The check !(size & (pageSize() - 1)) fails because of that.

Comment 1

[Mike Hommey [:glandium]]

FWIW, I think there are much more places in the code that assume a page size of 4KB.

Comment 2

[Jan Horak [:jhorak]]

Attachment: ia64 assert patch 0.1

Tested attached patch with ia64 and together with patches from:
https://bugzilla.mozilla.org/show_bug.cgi?id=589735
works just fine.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Please put a checkin comment describing what the patch does either in the patch or in the bug?

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6ae580de997

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/b6ae580de997