empty relations returned to atk

RESOLVED FIXED in Firefox 8

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

Trunk
mozilla9
All
Linux
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(firefox8 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Regression from 641838, we add a relation to the set of relations in RefRelationSet() even if there is 0 targets.

This makes orca spew lots of back traces because atleast one target was expected, and otherwise makes using firefox with orca very bad.
(Assignee)

Comment 1

6 years ago
Created attachment 554881 [details] [diff] [review]
patch
Assignee: nobody → trev.saunders
Status: NEW → ASSIGNED
Attachment #554881 - Flags: review?(surkov.alexander)
Attachment #554881 - Flags: review?(bolterbugz)
Comment on attachment 554881 [details] [diff] [review]
patch

r=me by inspection. Please test it out.
Attachment #554881 - Flags: review?(surkov.alexander)
Attachment #554881 - Flags: review?(bolterbugz)
Attachment #554881 - Flags: review+
(Assignee)

Comment 3

6 years ago
(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 554881 [details] [diff] [review]
> patch
> 
> r=me by inspection. Please test it out.

yeah, alreadyu did, using it now to :)
(Assignee)

Comment 4

6 years ago
landed http://hg.mozilla.org/integration/mozilla-inbound/rev/e11c851aab48
http://hg.mozilla.org/mozilla-central/rev/e11c851aab48
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite?
Hardware: x86_64 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Version: unspecified → Trunk
(Assignee)

Comment 6

6 years ago
We don't have any machinary for testing the platform specific accessibility api code at the moment.  Fortunately   that code is generally a very thin wrapper.
Blocks: 641838
Flags: in-testsuite? → in-testsuite-
Not having the test framework isn't a reason to set in-testsuite-. Just keep the question mark.
Flags: in-testsuite- → in-testsuite?
(Assignee)

Comment 8

6 years ago
Comment on attachment 554881 [details] [diff] [review]
patch

This regression hsould be in aurora two since  641838 landed before  we branched but this hadn't yet.  This patch is very low risk and and only effects linux with a accessibility app running.  We've also found no regressions on trunk from it, so I doubt we'd find any before its released.  (In any cse I'm pretty sure this won't introduce any regressions.)  In theory we could fix the regrssion by backing out 641838.  However that would be a much bigger change, and would would probably involve backing out 678189 and 672515 as well.  So I think we really want to take this on aurora.

p.s. I really should have asked earlier, but I've been dealing with school
Attachment #554881 - Flags: review+ → approval-mozilla-aurora?
Comment on attachment 554881 [details] [diff] [review]
patch

Reinstating my r+ which mysteriously evaporated.
Attachment #554881 - Flags: review+

Updated

6 years ago
Attachment #554881 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Landed on tbsaunde's behalf: http://hg.mozilla.org/releases/mozilla-aurora/rev/2ef302863818
status-firefox8: --- → fixed
You need to log in before you can comment on or make changes to this bug.