Closed
Bug 680945
Opened 11 years ago
Closed 11 years ago
Fold mailMessengerOverlay.xul into mailWindowOverlay.xul
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(seamonkey2.6 fixed)
RESOLVED
FIXED
seamonkey2.6
Tracking | Status | |
---|---|---|
seamonkey2.6 | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
7.01 KB,
patch
|
mnyromyr
:
review+
mnyromyr
:
superreview+
|
Details | Diff | Splinter Review |
At the moment newCard menuitem is inserted via an overlay which itself is overlayed by mailOverlay.xul. This can be done in a more simple manner by just overlaying mailWindowOverlay.xul with mailOverlay.xul and adding the xul for the menuitem to mailWindowOverlay.xul itself. This patch: * Adds the overlay to mailWindowOverlay.xul * Adds the newCard menuitem to menu_Newpopup * Removes loading of mailOverlay.xul from messenger.xul and messageWindow.xul * Removes mailMessengerOverlay.xul file and references to it. I've taken the opportunity to have the newCard menuitem in both 3-pane and standalone mail display window menus.
Attachment #554894 -
Flags: review?(mnyromyr)
Comment 1•11 years ago
|
||
Comment on attachment 554894 [details] [diff] [review] Fold in mailMessengerOverlay [Checked in: Comment 3] (After manually fixing the fuzz in jar.mn.)
Attachment #554894 -
Flags: review?(mnyromyr) → review+
Updated•11 years ago
|
Attachment #554894 -
Flags: superreview+
Comment on attachment 554894 [details] [diff] [review] Fold in mailMessengerOverlay [Checked in: Comment 3] http://hg.mozilla.org/comm-central/rev/e20d4f5a3521
Attachment #554894 -
Attachment description: Fold in mailMessengerOverlay → Fold in mailMessengerOverlay [Checked in: Comment 2]
Comment on attachment 554894 [details] [diff] [review] Fold in mailMessengerOverlay [Checked in: Comment 3] And this time the correct push link http://hg.mozilla.org/comm-central/rev/e50800b3c035
Attachment #554894 -
Attachment description: Fold in mailMessengerOverlay [Checked in: Comment 2] → Fold in mailMessengerOverlay [Checked in: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-seamonkey2.6:
--- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.6
You need to log in
before you can comment on or make changes to this bug.
Description
•