681071 - Lower the boom on cross-compartment pointers

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

There's evidence in bug 670702 that we still have problems with pointers that cross into other compartments without the right wrappers. Right now we check for this during Mark. This patch adds new assertions so that hopefully we can catch these problems right away. These checks will be expensive so I'll probably back them out after a week. They shouldn't affect our benchmarking of development builds because they'll only be enabled in actual nightly builds.

I also found a stupid bug in my instrumentation that caused some asserts and poisoning to be disabled in debug builds. This fixes that.

Comment 1

[David Mandelin [:dmandelin]]

Comment on attachment 554971 [details] [diff] [review]
patch

Review of attachment 554971 [details] [diff] [review]:
-----------------------------------------------------------------

Just be sure to coordinate with TI landing if this might affect that.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I checked with Brian; he says it shouldn't be a problem.

Comment 3

[Ed Morley [:emorley]]

http://hg.mozilla.org/mozilla-central/rev/d4003f345b24