crash PL_DHashTableEnumerate in the DOM memory reporter

RESOLVED FIXED in mozilla9

Status

()

Core
DOM
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Usul, Assigned: mounir)

Tracking

({crash})

Trunk
mozilla9
All
Android
crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound], crash signature)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
This bug was filed from the Socorro interface and is 
report bp-e4666f13-6df5-4e1e-9149-029df2110823 .
============================================================= 

Got there while trying to open about:memory
(Reporter)

Updated

6 years ago
Component: General → DOM
Product: Fennec → Core
QA Contact: general → general
Summary: crash PL_DHashTableEnumerate → crash PL_DHashTableEnumerate in the DOM memory reporter
It's a null-deref; is it possible for |windows| to come back null?  I'd think so, if the IPC message races shutdown.
(Reporter)

Comment 2

6 years ago
(In reply to Boris Zbarsky (:bz) from comment #1)
> It's a null-deref; is it possible for |windows| to come back null?  I'd
> think so, if the IPC message races shutdown.

I wasn't closing firefox on the mobile. Just trying to open about:memory.
Yes, but I'm talking about shutdown of the content process, not the chrome process.  I wouldn't expect it to be happening in this case yet, so presumably the null is for a different reason, but once we move to process-per-tab content processes will be shutting down all the time.
(Assignee)

Comment 4

6 years ago
Created attachment 555353 [details] [diff] [review]
Patch v1

Let's try that patch.

I see only two reasons why |windows| could be null: whether nsGlobalWindow ctor has never been called or nsGlobalWindow::Shutdown has been called. I have a patch adding a ::Init method to nsGlobalWindow which would remove the requirement of nsGlobalWindow ctor being called. Though, it seems unlikely that the ctor isn't called... but I don't know that much our e10s architecture...

Anyway, this patch should not hurt I believe ;)
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #555353 - Flags: review?(bzbarsky)
(Assignee)

Updated

6 years ago
OS: Linux → Android
Hardware: Other → All
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
Comment on attachment 555353 [details] [diff] [review]
Patch v1

r=me
Attachment #555353 - Flags: review?(bzbarsky) → review+
Whiteboard: [needs review] → [needs landing]
(Assignee)

Comment 6

6 years ago
I don't know how, I didn't see this review has been done... Thanks for the reminder Boris :)
Whiteboard: [needs landing] → [inbound]
http://hg.mozilla.org/mozilla-central/rev/80a4a3d420ea
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.