Last Comment Bug 681211 - crash PL_DHashTableEnumerate in the DOM memory reporter
: crash PL_DHashTableEnumerate in the DOM memory reporter
Status: RESOLVED FIXED
[inbound]
: crash
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All Android
: -- critical (vote)
: mozilla9
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-23 02:56 PDT by Ludovic Hirlimann [:Usul]
Modified: 2011-08-31 01:58 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (678 bytes, patch)
2011-08-24 03:38 PDT, Mounir Lamouri (:mounir)
bzbarsky: review+
Details | Diff | Review

Description Ludovic Hirlimann [:Usul] 2011-08-23 02:56:58 PDT
This bug was filed from the Socorro interface and is 
report bp-e4666f13-6df5-4e1e-9149-029df2110823 .
============================================================= 

Got there while trying to open about:memory
Comment 1 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-08-23 07:09:47 PDT
It's a null-deref; is it possible for |windows| to come back null?  I'd think so, if the IPC message races shutdown.
Comment 2 Ludovic Hirlimann [:Usul] 2011-08-23 07:12:56 PDT
(In reply to Boris Zbarsky (:bz) from comment #1)
> It's a null-deref; is it possible for |windows| to come back null?  I'd
> think so, if the IPC message races shutdown.

I wasn't closing firefox on the mobile. Just trying to open about:memory.
Comment 3 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-08-23 09:44:35 PDT
Yes, but I'm talking about shutdown of the content process, not the chrome process.  I wouldn't expect it to be happening in this case yet, so presumably the null is for a different reason, but once we move to process-per-tab content processes will be shutting down all the time.
Comment 4 Mounir Lamouri (:mounir) 2011-08-24 03:38:03 PDT
Created attachment 555353 [details] [diff] [review]
Patch v1

Let's try that patch.

I see only two reasons why |windows| could be null: whether nsGlobalWindow ctor has never been called or nsGlobalWindow::Shutdown has been called. I have a patch adding a ::Init method to nsGlobalWindow which would remove the requirement of nsGlobalWindow ctor being called. Though, it seems unlikely that the ctor isn't called... but I don't know that much our e10s architecture...

Anyway, this patch should not hurt I believe ;)
Comment 5 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-08-24 08:57:28 PDT
Comment on attachment 555353 [details] [diff] [review]
Patch v1

r=me
Comment 6 Mounir Lamouri (:mounir) 2011-08-30 02:42:58 PDT
I don't know how, I didn't see this review has been done... Thanks for the reminder Boris :)
Comment 7 Marco Bonardo [::mak] 2011-08-31 01:58:10 PDT
http://hg.mozilla.org/mozilla-central/rev/80a4a3d420ea

Note You need to log in before you can comment on or make changes to this bug.