68130 - CBrowserContainer::FindNamedBrowserItem implemented but not declared

Status: RESOLVED WONTFIX

(Core Graveyard :: Java APIs to WebShell, defect)

Description

[Marcus Fellinger]

Hello,

Could someone tell me why mozilla/java/webclient/src_moz/CBrowserContainer.cpp
implements method

CBrowserContainer::FindNamedBrowserItem(const PRUnichar *aName,
nsIDocShellTreeItem **_retval)

but CBrowserContainer.h doesn't declare any method of that name?

If I remove the implementation, remove -lxpfelocation_s from Makefile.in, and
change nsIProfile to nsIProfileInternal in NativeEventThread.cpp (bug #67679),
then moz_src builds without error.

TIA,
Marcus Fellinger
Tomcat Computer GmbH

Comment 1

[Marcus Fellinger]

Attachment: This patch removes the implementation of CBrowserContainer::FindNamedBrowserItem.

Comment 2

[edburns]

Good observation Marcus,

I'm going to reassign this to Ashu.

Comment 3

[Ashu Kulkarni]

I think the CBrowserContainer::FindNamedBrowserItem( ) declaration and the 
changes in the Makefile and NativeEventThread.cpp are 2 diff things.

First, I want to know if you are having problems building src_moz against 
Netscape 6 (commercial release) with the codebase that is currently in the 
JAVADEV_RTM_20001102 tagged branch of Blackwood? When you say, making these 
changes allowed you to build src_moz, do you mean against the tip of the 
Mozilla tree?

- CBrowserContainer::FindNamedBrowserItem( ) is declared in 
CBrowserContainer.cpp because it is a part of the nsIWebBrowserChrome Interface 
as of the Netscape 6 release codebase. Since this is the browser codebase we 
are targetting for now, I wouldn't want to change this. The reason it is not 
declared in CBrowserContainer.h is that it does not need to be. We are 
including nsIWebBrowserChrome.h in CBrowserContainer.h
- If changing nsIProfile to nsIProfileInternal in NativeEventThread.cpp allows 
us to get away without linking xpfelocation_s, I am all for it. However, i dont 
see any such IDL in the Netscape 6 codebase.

Pls note that Webclient will be released to work with the commercial Netscape 6 
binaries in the next Webclient release. Only after that, we will start trying 
to sync up with the Mozilla tip.

Your fix will be very useful when we make this transition and so I shall keep 
this Bug open with a Low priority. If however, I have completely missed your 
point here pls let me know.

thnx much
_Ashu

Comment 4

[Marcus Fellinger]

Hi Ashu, many thanks for your comments.

I'm currently trying to use the code in java (xpcom-bridge, dom, webclient) with
the tip. Also, I need a version which will not require mozilla to be build with
debugging enabled, as, according to Ed Burns, loading the Java-Plugin requires a
mozilla build with debugging disabled.

I didn't know that Netscape 6 is the target for Webclient. I thought that
everything in the tree should work with the tip, as I haven't seen a README in
the java/ subtree stating otherwise.

I will test if the problem still exists if I check out with the tag you provided.

PS: mozilla/java/README that one needs a sucessfully built MOZ_DEBUG=1 Mozilla
M13 tree. Shouldn't that be updated to indicate a newer release then?

Comment 5

[Ashu Kulkarni]

You are right about the README files and other documentation being out of date. 
We plan to make a release of Webclient (Release 1.0) sometime early next month. 
We will make sure that the Web documentation and README files are updated peior 
to this release.

You can get the Tag for the Mozilla codebase that will work with Webclient from 
writing to the Mozilla newsgroups on thro irc.mozilla.org. Alternately you 
could use Netscape_6_0_OEM_BRANCH. For Blackwood you should use 
JAVADEV_RTM_20001102.

All the best.

_Ashu

Comment 6

[Ashu Kulkarni]

Closing this Bug for now. When we start the work to sync up with Mozilla Tree 
TIP, I will open a Bug with a more appropriate subject line. Meanwhile all 
patches to help sync Webclient with the TIP would be greatly appreciated. You 
could post these fixes to this Bug.

thnx
_Ashu