68135 - [FIX][LST][EVT]onchange of SELECT MULTIPLE doesn't fire when OPTION is deselected

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Martin Honnen]

The onchange event handler of a SELECT MULTIPLE element should fire when the
user deselects a selected OPTION with Ctrl-Click but it doesn't in Mozilla

<SELECT NAME="selectName"
        ONCHANGE="document.getElementById('output').innerHTML +=
                   event.type + ' at ' + new Date() + '; selectedIndex = ' +
this.selectedIndex + '<BR>';"
        SIZE="2"
        MULTIPLE
>
<OPTION>Kibo
<OPTION>Maho
</SELECT>
<DIV ID="output"></DIV>

Comment 1

[Martin Honnen]

Attachment: bug demo (click OPTION then deselect it with Ctrl-click and onchange doesn't fire)

Comment 2

[Johnny Stenback (:jst)]

Rod, not sure if this belongs to you or Tom, please reassign if it's not your bug.

Comment 3

[rods (gone)]

I'll take a look for 0.9.1

Comment 4

[rods (gone)]

Attachment: patch

Comment 5

[Marc Attinasi]

Patch looks fine. I'd move the comment below inside the if, and fix the typo

+        // didn't find any other seleccted items
+        // so we must set the currently selected item to "-1"
+        // this also forces the dispatch of the onchange event
+        if (i == max) {
+          mSelectedIndex = -1;
+        }

[s]r=attinasi

Comment 6

[Kevin McCluskey (gone)]

r=[e-mail]

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin (on behalf of drivers), assuming you've tested the
javascript on the bugzilla query page Component selection and it doesn't do
anything strange, like loop infinitely (and perhaps tested some other
bugzilla-related stuff)

Comment 8

[rods (gone)]

fixed