681432 - Fennec does not display addons with 3rd party addon types in addon manager

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[Erik Vold]

I'm working on a branch of Scriptish for Fennec, https://github.com/erikvold/scriptish/tree/fennec , and I was hoping that the addon manager for Fennec would display 3rd party addons like the FF addon manager does =]

Is that the plan?

Comment 1

[[:fabrice] Fabrice Desré]

It displays add-ons installed from any http source, so I'm not sure which kind of issue you see here.

Comment 2

[Thomas Arend [:tarend]]

Hi Erik. As mentioned in Comment 1 we show installed add-ons from any http source. Please re-open this bug if you find an issue with this. If so, please let us know the details of the add-on that does NOT show in our add-on manager. Thanks!

Comment 3

[Erik Vold]

OK you guys clearly misunderstood what I was talking about..

In FF4 the AddonManager https://developer.mozilla.org/en/Addons/Add-on_Manager was introduced which allows third party addons to create new addons types. So extensions like Stylish and Greasemonkey can easily extend the EM with new addon types.

This does not seem possible with Fennec even though the AddonManager API seems intact..

Comment 4

[Erik Vold]

Since Fennec will be using a native UI, this may be more important.  Addons like Scriptish will not be able to support Fennec without this feature.

Comment 5

[:Margaret Leibovic]

Eric, is this still a problem? If it is, can you link to an XPI that demonstrates this problem, and elaborate on what you'd like us to do to fix this?

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to :Margaret Leibovic from comment #5)
> Eric, is this still a problem? If it is, can you link to an XPI that
> demonstrates this problem, and elaborate on what you'd like us to do to fix
> this?

I'll have to make a new add-on for this, the old one only worked on the pre-native Fennec.

I'll get to it eventually hopefully, I'm pretty sure that Blair would know if this still works or not though.

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] (work week -> pto) from comment #6)
> (In reply to :Margaret Leibovic from comment #5)
> > Eric, is this still a problem? If it is, can you link to an XPI that
> > demonstrates this problem, and elaborate on what you'd like us to do to fix
> > this?
> 
> I'll have to make a new add-on for this, the old one only worked on the
> pre-native Fennec.
> 
> I'll get to it eventually hopefully, I'm pretty sure that Blair would know
> if this still works or not though.

* still does not work

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

I don't generally touch the Fennec frontend implementation - it's completely independent from the Toolkit implementation, and maintained completely independently (for better or worse).

But I do know it's far less feature complete, and doesn't make the expected use of the provided AddonManager APIs. One such example is that it uses a hard-coded list of add-on types, rather than using AddonManager.addonTypes object and associated event handlers (the TypeListener interface). This ends up meaning that it only supports add-on types that it's hard-coded to support.

Comment 9

[Erik Vold [:erikvold] (please needinfo? me)]

I don't have time to look into this, I have 5+ projects that I have to work on right now, native jetpacks, jpm, add-ons as features, mochitestification & cfx test suite updates for the sdk, sdk uplifts, and various reviews across this scope.

Perhaps someone on the Fennec team can look into this?

Comment 10

[:Margaret Leibovic]

Attachment: MozReview Request: bz://681432/margaret

Comment 11

[:Margaret Leibovic]

/r/1321 - Bug 681432 - Support all add-on types in the add-on manager

Pull down this commit:

hg pull review -r 2369985310ec405df277f5e97262ae1acd224c39

Comment 12

[:Margaret Leibovic]

I wasn't able to reproduce this locally, since I don't have an example add-on that does this, but I believe this fix should be enough to fix this issue. I'm not sure why we only request certain add-on types as opposed to all add-ons. I assume this is just some historical artifact, so I think we can update this to get all add-ons.

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/1321/#review705

::: mobile/android/chrome/content/aboutAddons.js
(Diff revision 1)
> -    AddonManager.getAddonsByTypes(["extension", "theme", "locale"], function(aAddons) {
> +    AddonManager.getAllAddons(function(aAddons) {

I suppose this is safe enough. I don't expect to see many other types appearing for Fennec, although the new "experimental" type might be something we support sometime in the future.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

https://reviewboard.mozilla.org/r/1321/#review707

Ship It!

Comment 15

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #14)
> https://reviewboard.mozilla.org/r/1321/#review707
> 
> Ship It!

Really?

Comment 16

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/c310bb6e6bc6

I guess a "ship it" in rb doesn't automatically set an r+ in the bug?

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c310bb6e6bc6

Comment 18

[:Margaret Leibovic]

Comment on attachment 8533359 [details]
MozReview Request: bz://681432/margaret

(The r+ happened in review board)

Comment 20

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 681432 - Support all add-on types in the add-on manager