681651 - Move Highlighter's TreePanel associated code to browser/devtools

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

We should move treepanel-related code (for the highlighter) to browser/devtools.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Attachment: move treepanel code to devtools

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 555408 [details] [diff] [review]
move treepanel code to devtools

Review of attachment 555408 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine. r+! Please update for the comment below.

::: browser/devtools/highlighter/Makefile.in
@@ +46,5 @@
> +ifdef ENABLE_TESTS
> +ifneq (mobile,$(MOZ_BUILD_APP))
> +# 	DIRS += test # tests still in browser/base/content/test/inspector
> +endif
> +endif

According to bug 660784 comment 27 you don't need the ifneq check for mobile.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Attachment: move treepanel code to devtools

updated patch to move treepanel-related code to devtools. Fixed up some makefile license blocks in devtools/ and devtools/scratchpad while I was in there. (do we even need license blocks on build code?)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Can you fold the relevant portions of this into bug 650794's patch? That'd make it easier to review these.

Comment 5

[Rob Campbell [:rc] (:robcee)]

(In reply to Gavin Sharp from comment #4)
> Can you fold the relevant portions of this into bug 650794's patch? That'd
> make it easier to review these.

WILCO.

Comment 6

[Rob Campbell [:rc] (:robcee)]

fixed in bug 650794.