Closed
Bug 681651
Opened 12 years ago
Closed 12 years ago
Move Highlighter's TreePanel associated code to browser/devtools
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 9
People
(Reporter: rcampbell, Assigned: rcampbell)
References
Details
(Whiteboard: [minotaur][has-patch])
Attachments
(1 file, 1 obsolete file)
8.69 KB,
patch
|
Details | Diff | Splinter Review |
We should move treepanel-related code (for the highlighter) to browser/devtools.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee | ||
Updated•12 years ago
|
Whiteboard: [minotaur] → [minotaur][has-patch]
Comment 2•12 years ago
|
||
Comment on attachment 555408 [details] [diff] [review] move treepanel code to devtools Review of attachment 555408 [details] [diff] [review]: ----------------------------------------------------------------- Patch looks fine. r+! Please update for the comment below. ::: browser/devtools/highlighter/Makefile.in @@ +46,5 @@ > +ifdef ENABLE_TESTS > +ifneq (mobile,$(MOZ_BUILD_APP)) > +# DIRS += test # tests still in browser/base/content/test/inspector > +endif > +endif According to bug 660784 comment 27 you don't need the ifneq check for mobile.
Attachment #555408 -
Flags: review?(mihai.sucan) → review+
Assignee | ||
Comment 3•12 years ago
|
||
updated patch to move treepanel-related code to devtools. Fixed up some makefile license blocks in devtools/ and devtools/scratchpad while I was in there. (do we even need license blocks on build code?)
Attachment #555408 -
Attachment is obsolete: true
Attachment #555761 -
Flags: review?(gavin.sharp)
Assignee | ||
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Comment 4•12 years ago
|
||
Can you fold the relevant portions of this into bug 650794's patch? That'd make it easier to review these.
Assignee | ||
Comment 5•12 years ago
|
||
(In reply to Gavin Sharp from comment #4) > Can you fold the relevant portions of this into bug 650794's patch? That'd > make it easier to review these. WILCO.
Assignee | ||
Updated•12 years ago
|
Attachment #555761 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 6•12 years ago
|
||
fixed in bug 650794.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → Firefox 9
Updated•5 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•