The default bug view has changed. See this FAQ.

Move Highlighter's TreePanel associated code to browser/devtools

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [minotaur][has-patch])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
We should move treepanel-related code (for the highlighter) to browser/devtools.
(Assignee)

Comment 1

6 years ago
Created attachment 555408 [details] [diff] [review]
move treepanel code to devtools
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #555408 - Flags: review?(mihai.sucan)
(Assignee)

Updated

6 years ago
Depends on: 650794
(Assignee)

Updated

6 years ago
Whiteboard: [minotaur] → [minotaur][has-patch]
Comment on attachment 555408 [details] [diff] [review]
move treepanel code to devtools

Review of attachment 555408 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine. r+! Please update for the comment below.

::: browser/devtools/highlighter/Makefile.in
@@ +46,5 @@
> +ifdef ENABLE_TESTS
> +ifneq (mobile,$(MOZ_BUILD_APP))
> +# 	DIRS += test # tests still in browser/base/content/test/inspector
> +endif
> +endif

According to bug 660784 comment 27 you don't need the ifneq check for mobile.
Attachment #555408 - Flags: review?(mihai.sucan) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 555761 [details] [diff] [review]
move treepanel code to devtools

updated patch to move treepanel-related code to devtools. Fixed up some makefile license blocks in devtools/ and devtools/scratchpad while I was in there. (do we even need license blocks on build code?)
Attachment #555408 - Attachment is obsolete: true
Attachment #555761 - Flags: review?(gavin.sharp)
(Assignee)

Updated

6 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

6 years ago
Blocks: 672002
Can you fold the relevant portions of this into bug 650794's patch? That'd make it easier to review these.

Updated

6 years ago
Blocks: 562168
(Assignee)

Comment 5

6 years ago
(In reply to Gavin Sharp from comment #4)
> Can you fold the relevant portions of this into bug 650794's patch? That'd
> make it easier to review these.

WILCO.
(Assignee)

Updated

6 years ago
Attachment #555761 - Flags: review?(gavin.sharp)

Updated

6 years ago
No longer blocks: 562168
(Assignee)

Comment 6

6 years ago
fixed in bug 650794.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: --- → Firefox 9
Blocks: 703275
You need to log in before you can comment on or make changes to this bug.