Closed Bug 681660 Opened 10 years ago Closed 10 years ago

[win] GetDiskSpaceAvailable doesn't work on files

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla9

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

patch v1.0
2.44 KB, patch
jimm
: review+
Details | Diff | Splinter Review 
This works:
Components.utils.import("resource://gre/modules/Services.jsm"); var profile = Services.dirsvc.get("ProfD", Components.interfaces.nsILocalFile); profile.diskSpaceAvailable;

This returns 0:
Components.utils.import("resource://gre/modules/Services.jsm"); var file = Services.dirsvc.get("ProfD", Components.interfaces.nsILocalFile); file.append("places.sqlite"); file.diskSpaceAvailable;

It returns 0 because GetDiskFreeSpaceExW returns 0 (thus it fails)
Summary: GetDiskSpaceAvailable works only on nsILocalFile representing folders → [win] GetDiskSpaceAvailable works only on nsILocalFile representing folders
and that is not so wrong since the first argument to GetDiskFreeSpaceExW is lpDirectoryName... it must be a directory, probably if the nsILocalFile is a file we should rather query its parent directory
tentatively taking
Assignee: nobody → mak77
Flags: in-testsuite?
Attached patch patch v1.0 — — Splinter Review
Attachment #555580 - Flags: review?(jmathies)
Summary: [win] GetDiskSpaceAvailable works only on nsILocalFile representing folders → [win] GetDiskSpaceAvailable doesn't work on files
Blocks: 674210
Attachment #555580 - Flags: review?(jmathies) → review+
http://hg.mozilla.org/mozilla-central/rev/7dab2bc1cc91
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla9
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.