681704 - CRT ASSERT strftime.c(833) : Assertion failed: ( "Invalid format directive" , 0 ) in js1_5/extensions/toLocaleFormat-02.js

Status: RESOLVED DUPLICATE of bug 818634

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

1. apply patch in https://bugzilla.mozilla.org/show_bug.cgi?id=587982
2. run js1_5/extensions/toLocaleFormat-02.js in the browser

js1_5/extensions/toLocaleFormat-02.js on WinXP fails with 

ABORT: CRT ASSERT strftime.c(833) : Assertion failed: ( "Invalid format directive" , 0 )

Win7 also fails but it is missing the ABORT message in the log at the moment.

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-0b488974dd3f/try-win32-debug/try_xp-debug_test-jsreftest-build532.txt.gz

http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-0b488974dd3f/try-win32-debug/try_win7-debug_test-jsreftest-build650.txt.gz

Question: In bug 587982, I made CRT assertions as well as CRT errors fatal. Is that appropriate or should it have been non-fatal?

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: patch to disable test

This blocks adding CRT Debug aborts in bug 587982. I ran jstestbrowser with this test disabled and passed.

Comment 2

[Bob Clary [:bc] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ca10f967b05

Do not mark this fixed when this lands on mozilla-central. The underlying bug is still there.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/7ca10f967b05

Comment 4

[Jim Mathies [:jimm]]

I just got one of these while debugging metrofx. bing.com was the page loaded. the browser was sitting for a bit without interaction and then it crashed. Will attach a stack.

Comment 5

[Jim Mathies [:jimm]]

Attachment: crash stack

Comment 6

[Jim Mathies [:jimm]]

f:\dd\vctools\crt_bld\self_x86\crt\src\strftime.c(798) : Assertion failed: ( "Invalid format directive" , 0 )

strftime params:

buf: 0x03386eac "Sun Iø\ti\x6"
buflen: 100
fmt: 0x0b9d3fa0 "%a %R"

Comment 7

[Jim Mathies [:jimm]]

The observer event was "weave:service:login:finish"

Comment 8

[André Bargull [:anba]]

toLocaleFormat was removed in bug 818634.