681720 - Switch to pyxpidl in comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Joshua Cranmer [:jcranmer]]

I have a patch floating about which I will attach shortly that switches this to use pyxpidl like mozilla-central does. This should be the last thing necessary to remove native xpidl.

Comment 1

[Justin Wood (:Callek)]

Josh, looks like our dependancies are resolved, can you test, see if we need to file any more, and get your patch up?

Comment 2

[Joshua Cranmer [:jcranmer]]

Attachment: Switch to pyxpidl

This compiles locally for me; I've pushed it to try as well: http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=6fdcdaa75f83

Comment 3

[Joshua Cranmer [:jcranmer]]

Sorry, it would help if I actually chose a non-no0op build: <http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry&rev=4cdd2aafe111>.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 556419 [details] [diff] [review]
Switch to pyxpidl

>diff --git a/config/config.mk b/config/config.mk
>-ifdef CROSS_COMPILE
>-XPIDL_COMPILE 	= $(CYGWIN_WRAPPER) $(LIBXUL_DIST)/host/bin/host_xpidl$(HOST_BIN_SUFFIX)
>-else
>-XPIDL_COMPILE 	= $(CYGWIN_WRAPPER) $(LIBXUL_DIST)/bin/xpidl$(BIN_SUFFIX)
>-endif

Do we have a reason for diverging from m-c here, would this break cross compiles?

>diff --git a/config/rules.mk b/config/rules.mk
>--- a/config/rules.mk
>+++ b/config/rules.mk

You should change http://mxr.mozilla.org/comm-central/source/config/rules.mk#403 to |MDDEPFILES += $(addprefix $(MDDEPDIR)/,$(XPIDLSRCS:.idl=.h.pp) $(XPIDLSRCS:.idl=.xpt.pp))| as in m-c.

Other than that r+, but I want an answer as to "why" on the XPIDL_COMPILE bit.

Comment 5

[Justin Wood (:Callek)]

(In reply to Justin Wood (:Callek) from comment #4)
> Do we have a reason for diverging from m-c here, would this break cross
> compiles?
> ...
> Other than that r+, but I want an answer as to "why" on the XPIDL_COMPILE
> bit.

Actually looked again, and I see that we are safe to remove that in c-c, I do see it in use in m-c, in ONLY one spot, and as such probably defeats the purpose of this test.
http://mxr.mozilla.org/comm-central/source/mozilla/xpcom/tests/Makefile.in#196

We should probably file a bug on it.

Comment 6

[Joshua Cranmer [:jcranmer]]

Pushed:
changeset:   8389:ddfd4732d622

Comment 7

[Joshua Cranmer [:jcranmer]]

> We should probably file a bug on it.

Bug 682852

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

This seems to cause calendar test failures, see bug 683096. Maybe someone with more xpcom knowledge can take a look there?