681733 - Don't create the HiddenWindow on android

Status: RESOLVED INVALID

(GeckoView :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

I don't think we have any good reason to have a hidden window there. I tried building without it and things seemed to work.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

B2G removed theirs in http://hg.mozilla.org/mozilla-central/rev/b28b70e9017b so I'm just piggybacking on that.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c10417c14cf

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8593342 [details] [diff] [review]
Patch

Happy to see how this works. Thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cfb6c36caf63

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cfb6c36caf63

Comment 6

[Erik Vold [:erikvold] (please needinfo? me)]

So this breaks the add-on sdk's sdk/page-worker and sdk/addon/window modules.  This API is necessary to create Google Chrome like background windows afiact.

It also breaks every add-on sdk made for Fennec, bug 1156069.  May we revert this, or is there some other means of implementation the sdk should be using?

Comment 7

[Kartikaya Gupta (email:[e-mail])]

I backed this out in https://hg.mozilla.org/integration/mozilla-inbound/rev/1be028412d66 (I thought pulsebot would comment but I guess not...). Before we can reland this we need to make the add-on SDK stop using the hidden window, which requires fixing bug 946015.

Comment 8

[Dailin Zhang]

I want to fix this bug, somebody could assigned me to this bug???thanks

Comment 9

[David Lawrence [:dkl]]

Moving all open Core::Widget: Android bugs to GeckoView::General (then the triage owner of GeckoView will decide which ones are valuable and which ones should be closed).

Comment 10

[Emily Toop (:fluffyemily)]

Not applicable to GeckoView