681840 - Print helpful warning when starting test HTTP server fails

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

gps just got bit by this. Not letting perfect be the enemy of good, let's log something useful when the test server port is already in use.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

Turns out that the error is thrown on the calling thread, so we can easily get output during tests like:


TEST-INFO | (xpcshell/head.js) | test 2 pending
==========================================
Got exception starting HTTP server on port 8080
Error: 2147746065 No traceback available
Is there a process already listening on port 8080?
==========================================
 
TEST-UNEXPECTED-FAIL | /home/gps/src/mozilla-central/obj-ff-debug/_tests/xpcshell/services/sync/tests/unit/head_http_server.js | 2147746065 - See following stack:


That's what this patch does. It'd be nice if httpd.js threw Components.Exceptions instead of raw error codes, but this will do for now. gps confirmed that this would have clued him in sooner :)

Sync unit tests pass.

Comment 2

[Philipp von Weitershausen [:philikon]]

Comment on attachment 556101 [details] [diff] [review]
Proposed patch. v1

Nit: Trailing whitespace.

Comment 3

[Richard Newman [:rnewman]]

https://hg.mozilla.org/services/services-central/rev/62177ac1ccad

and fixing the darn whitespace that I shouldn't have included in the first place:

https://hg.mozilla.org/services/services-central/rev/74a49fef4fc4

QA: In principle this is testable -- start an HTTP server on port 8080, verify that you get a pretty error message when running a test that requires HTTP -- but don't spend too much time on it.

Comment 4

[Philipp von Weitershausen [:philikon]]

http://hg.mozilla.org/mozilla-central/rev/62177ac1ccad
http://hg.mozilla.org/mozilla-central/rev/74a49fef4fc4